Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

`before_deploy` not being run #2550

Closed
lucky opened this Issue Jul 22, 2014 · 6 comments

Comments

Projects
None yet
4 participants

lucky commented Jul 22, 2014

I have a project set up to use a before_deploy script that prepares it for upload. However, as of today that script is not being run.

Owner

svenfuchs commented Jul 22, 2014

@henrikhodne Could you please look into this?

Contributor

henrikhodne commented Jul 22, 2014

Fix is here: travis-ci/travis-build@6b825f6. Waiting for CI to pass, then I'll deploy on .org, then on .com.

Contributor

henrikhodne commented Jul 22, 2014

(For some reason the tests we have to test that before_deploy and after_deploy are run pass even though they aren't run -- will have to investigate why that is. In the meantime I have manually confirmed that this change fixes the issue.)

Contributor

henrikhodne commented Jul 22, 2014

Deployed the fix to .org. It takes a little while for everything to actually roll out. I'm monitoring things and plan to roll out to .com soon if things are working well.

Contributor

henrikhodne commented Jul 22, 2014

Fix should be deployed to both .org and .com now.

@lucky Could you check and see if this is still an issue for you?

Owner

joshk commented Jul 23, 2014

Closing this as we have had reports everything is working as it should.

Please open a new ticket if you continue to have any problems.

High 5.

@joshk joshk closed this Jul 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment