New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP] HHVM xml parsing issues #2863
Comments
This looks like HHVM issue to me. Please report the issue to https://github.com/facebook/hhvm. If the issue turns out to be on our end, we'll investigate. |
you may need to rollback to HHVM 3.2 then .. because this will break a lot of test suites |
opened facebook/hhvm#3974 |
Reproduced in the VM, also running with HHVM-3.3.0-0-g0a3cfb87b8a353fc7e1d15374f4adc413e37aba9 After adding the ini param from facebook/hhvm#3974 (comment) the ci runs localy without errors. In hhvm.libxml.ext_entity_whitelist=file,http,https |
This sounds like a compromise between rolling back and waiting for the next HHVM fix. I'll reopen this. @BanzaiMan wdyt? |
agreed |
👍 to @dazz's patch to |
Putting back |
Is there an alternative file location that hhvm would look at and that would take precedence over |
We added our own
|
@loicfrering hey buddy, do you think we could solve this with php-env? eg. when we install hhvm-nightly it would add an ini file as an after install step? |
I should mention that we tried tinkering with |
situation is a bit problematic atm as several projects now fail with HHVM. would you consider a rollback to HHVM 3.2? I really do not want to complicate our test setup with too much HHVM specific instructions. The other alternative is of course to just drop HHVM testing for now .. /cc @sgolemon |
this hits about every symfony bundle doing tests, for example FriendsOfSymfony/FOSHttpCacheBundle#153 |
@BanzaiMan isn't it possible to put this config back for HHVM stable at least ? |
I'll look into the hack today. |
Fix is suggested by travis-ci/travis-ci#2863 (comment)
Fix is suggested by travis-ci/travis-ci#2863 (comment)
I tested the suggested workaround, but it doesn't seem to solve a problem initially reported. https://staging.travis-ci.org/BanzaiMan/FOSRestBundle/builds/392534#L160-L161 shows that this job has the desired entry in |
there is a weird thing in the XSD path appearing in the error message. There is 4 slashes after |
The number of slashes after the protocol should not be a problem, as long as there are at least 3. In other words, |
If HHVM is not doing that, then, yes, that's a bug. |
this is a work around .. but its imho too messy to really be acceptable: |
We need to run this before paranoid_mode disables sudo This fixes travis-ci/travis-ci#2863 and travis-ci/travis-ci#2523.
It's been shipped, so please test your HHVM jobs without the workaround. Thank you! |
looks good! https://travis-ci.org/FriendsOfSymfony/FOSRestBundle/jobs/40057391 thx for your work! |
Very helpful, thank you! |
hhm-nightly is still broken: https://travis-ci.org/phpspec/phpspec/jobs/40279263 |
Sorry, the fix has been lost during a deploy. We'll fix this Monday. |
https://travis-ci.org/FriendsOfSymfony/FOSRestBundle/jobs/37943927
https://travis-ci.org/doctrine/DoctrinePHPCRBundle/jobs/37943272
not sure if this is just a bug in the version of HHVM or if there was an issue with how it was compiled.
The text was updated successfully, but these errors were encountered: