[PHP] HHVM xml parsing issues #2863

Closed
lsmith77 opened this Issue Oct 14, 2014 · 28 comments

Comments

Projects
None yet
9 participants
@lsmith77

https://travis-ci.org/FriendsOfSymfony/FOSRestBundle/jobs/37943927
https://travis-ci.org/doctrine/DoctrinePHPCRBundle/jobs/37943272

not sure if this is just a bug in the version of HHVM or if there was an issue with how it was compiled.

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Oct 14, 2014

Member

This looks like HHVM issue to me. Please report the issue to https://github.com/facebook/hhvm.

If the issue turns out to be on our end, we'll investigate.

Member

BanzaiMan commented Oct 14, 2014

This looks like HHVM issue to me. Please report the issue to https://github.com/facebook/hhvm.

If the issue turns out to be on our end, we'll investigate.

@BanzaiMan BanzaiMan closed this Oct 14, 2014

@lsmith77

This comment has been minimized.

Show comment
Hide comment
@lsmith77

lsmith77 Oct 14, 2014

you may need to rollback to HHVM 3.2 then .. because this will break a lot of test suites

you may need to rollback to HHVM 3.2 then .. because this will break a lot of test suites

@lsmith77

This comment has been minimized.

Show comment
Hide comment
@dazz

This comment has been minimized.

Show comment
Hide comment
@dazz

dazz Oct 15, 2014

Reproduced in the VM, also running with HHVM-3.3.0-0-g0a3cfb87b8a353fc7e1d15374f4adc413e37aba9

After adding the ini param from facebook/hhvm#3974 (comment) the ci runs localy without errors.

In /etc/hhvm/php.ini

hhvm.libxml.ext_entity_whitelist=file,http,https

dazz commented Oct 15, 2014

Reproduced in the VM, also running with HHVM-3.3.0-0-g0a3cfb87b8a353fc7e1d15374f4adc413e37aba9

After adding the ini param from facebook/hhvm#3974 (comment) the ci runs localy without errors.

In /etc/hhvm/php.ini

hhvm.libxml.ext_entity_whitelist=file,http,https
@svenfuchs

This comment has been minimized.

Show comment
Hide comment
@svenfuchs

svenfuchs Oct 15, 2014

Member

This sounds like a compromise between rolling back and waiting for the next HHVM fix. I'll reopen this.

@BanzaiMan wdyt?

Member

svenfuchs commented Oct 15, 2014

This sounds like a compromise between rolling back and waiting for the next HHVM fix. I'll reopen this.

@BanzaiMan wdyt?

@svenfuchs svenfuchs reopened this Oct 15, 2014

@lsmith77

This comment has been minimized.

Show comment
Hide comment

agreed

@meatballhat

This comment has been minimized.

Show comment
Hide comment
@meatballhat

meatballhat Oct 15, 2014

Member

👍 to @dazz's patch to /etc/hhvm/php.ini iiuc

Member

meatballhat commented Oct 15, 2014

👍 to @dazz's patch to /etc/hhvm/php.ini iiuc

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Oct 15, 2014

Member

Putting back /etc/hhvm/php.ini breaks hhvm-nightly. I guess I'll add a hack on travis-build, but, in all honesty, I feel that this is something HHVM team should fix.

Member

BanzaiMan commented Oct 15, 2014

Putting back /etc/hhvm/php.ini breaks hhvm-nightly. I guess I'll add a hack on travis-build, but, in all honesty, I feel that this is something HHVM team should fix.

@svenfuchs

This comment has been minimized.

Show comment
Hide comment
@svenfuchs

svenfuchs Oct 15, 2014

Member

Is there an alternative file location that hhvm would look at and that would take precedence over /etc/hhvm/php.ini? If so, users could just copy and modify the files in a before_script step.

Member

svenfuchs commented Oct 15, 2014

Is there an alternative file location that hhvm would look at and that would take precedence over /etc/hhvm/php.ini? If so, users could just copy and modify the files in a before_script step.

@dazz

This comment has been minimized.

Show comment
Hide comment
@dazz

dazz Oct 15, 2014

We added our own travis.hhvm.ini and call the ci commands for hhvm with the -c option to load our own config

hhvm -c travis.hhvm.ini ./vendor/bin/phpmd ...

dazz commented Oct 15, 2014

We added our own travis.hhvm.ini and call the ci commands for hhvm with the -c option to load our own config

hhvm -c travis.hhvm.ini ./vendor/bin/phpmd ...

@joshk

This comment has been minimized.

Show comment
Hide comment
@joshk

joshk Oct 16, 2014

Member

@loicfrering hey buddy, do you think we could solve this with php-env? eg. when we install hhvm-nightly it would add an ini file as an after install step?

Member

joshk commented Oct 16, 2014

@loicfrering hey buddy, do you think we could solve this with php-env? eg. when we install hhvm-nightly it would add an ini file as an after install step?

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Oct 16, 2014

Member

I should mention that we tried tinkering with /etc/hhvm/php.ini before. See #2523.

Member

BanzaiMan commented Oct 16, 2014

I should mention that we tried tinkering with /etc/hhvm/php.ini before. See #2523.

@lsmith77 lsmith77 referenced this issue in facebook/hhvm Oct 16, 2014

Closed

xml parsing issues with HHVM 3.3 #3974

@lsmith77

This comment has been minimized.

Show comment
Hide comment
@lsmith77

lsmith77 Oct 18, 2014

situation is a bit problematic atm as several projects now fail with HHVM. would you consider a rollback to HHVM 3.2? I really do not want to complicate our test setup with too much HHVM specific instructions. The other alternative is of course to just drop HHVM testing for now ..

/cc @sgolemon

situation is a bit problematic atm as several projects now fail with HHVM. would you consider a rollback to HHVM 3.2? I really do not want to complicate our test setup with too much HHVM specific instructions. The other alternative is of course to just drop HHVM testing for now ..

/cc @sgolemon

@dbu dbu referenced this issue in FriendsOfSymfony/FOSHttpCacheBundle Oct 21, 2014

Merged

hhvm broke their xml support. ignore it until they can fix it #153

@dbu

This comment has been minimized.

Show comment
Hide comment
@dbu

dbu Oct 21, 2014

this hits about every symfony bundle doing tests, for example FriendsOfSymfony/FOSHttpCacheBundle#153

dbu commented Oct 21, 2014

this hits about every symfony bundle doing tests, for example FriendsOfSymfony/FOSHttpCacheBundle#153

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Oct 21, 2014

@BanzaiMan isn't it possible to put this config back for HHVM stable at least ?

stof commented Oct 21, 2014

@BanzaiMan isn't it possible to put this config back for HHVM stable at least ?

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Oct 21, 2014

Member

I'll look into the hack today.

Member

BanzaiMan commented Oct 21, 2014

I'll look into the hack today.

BanzaiMan added a commit to travis-ci/travis-build that referenced this issue Oct 21, 2014

BanzaiMan added a commit to travis-ci/travis-build that referenced this issue Oct 21, 2014

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Oct 21, 2014

Member

I tested the suggested workaround, but it doesn't seem to solve a problem initially reported.

https://staging.travis-ci.org/BanzaiMan/FOSRestBundle/builds/392534#L160-L161 shows that this job has the desired entry in /etc/hhvm/php.ini, but subsequent tests still fail.

Member

BanzaiMan commented Oct 21, 2014

I tested the suggested workaround, but it doesn't seem to solve a problem initially reported.

https://staging.travis-ci.org/BanzaiMan/FOSRestBundle/builds/392534#L160-L161 shows that this job has the desired entry in /etc/hhvm/php.ini, but subsequent tests still fail.

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Oct 21, 2014

there is a weird thing in the XSD path appearing in the error message. There is 4 slashes after file:, while there should be only 3 AFAICT. Maybe there is another bug as well

stof commented Oct 21, 2014

there is a weird thing in the XSD path appearing in the error message. There is 4 slashes after file:, while there should be only 3 AFAICT. Maybe there is another bug as well

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Oct 21, 2014

Member

The number of slashes after the protocol should not be a problem, as long as there are at least 3. In other words, file://// should collapse to file:///, since // is the same as / on the file system.

Member

BanzaiMan commented Oct 21, 2014

The number of slashes after the protocol should not be a problem, as long as there are at least 3. In other words, file://// should collapse to file:///, since // is the same as / on the file system.

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Oct 21, 2014

Member

If HHVM is not doing that, then, yes, that's a bug.

Member

BanzaiMan commented Oct 21, 2014

If HHVM is not doing that, then, yes, that's a bug.

@lsmith77

This comment has been minimized.

Show comment
Hide comment
@lsmith77

lsmith77 Nov 6, 2014

this is a work around .. but its imho too messy to really be acceptable:
FriendsOfSymfony/FOSRestBundle#898

lsmith77 commented Nov 6, 2014

this is a work around .. but its imho too messy to really be acceptable:
FriendsOfSymfony/FOSRestBundle#898

@BanzaiMan BanzaiMan referenced this issue in travis-ci/travis-build Nov 6, 2014

Merged

Inject /etc/hhvm/php.ini in PHP's configure for HHVM #322

BanzaiMan added a commit to travis-ci/travis-build that referenced this issue Nov 6, 2014

Inject /etc/hhvm/php.ini in PHP's configure for HHVM
We need to run this before paranoid_mode disables sudo

This fixes travis-ci/travis-ci#2863 and
travis-ci/travis-ci#2523.
@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Nov 6, 2014

Member

It's been shipped, so please test your HHVM jobs without the workaround. Thank you!

Member

BanzaiMan commented Nov 6, 2014

It's been shipped, so please test your HHVM jobs without the workaround. Thank you!

@lsmith77

This comment has been minimized.

Show comment
Hide comment
@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius Nov 7, 2014

Very helpful, thank you!

Ocramius commented Nov 7, 2014

Very helpful, thank you!

@stof

This comment has been minimized.

Show comment
Hide comment

@dbu dbu referenced this issue in FriendsOfSymfony/FOSHttpCacheBundle Nov 7, 2014

Merged

revert #153 as hhvm setup on travis is fixed #157

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Nov 8, 2014

Member

Sorry, the fix has been lost during a deploy. We'll fix this Monday.

Member

BanzaiMan commented Nov 8, 2014

Sorry, the fix has been lost during a deploy. We'll fix this Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment