Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower vs. Uppercase or Vendor/Project-Names in Travis-CI URLs #3198

Closed
andygrunwald opened this issue Feb 8, 2015 · 17 comments

Comments

Projects
None yet
@andygrunwald
Copy link

commented Feb 8, 2015

There is a project on Github called TYPO3/TYPO3.CMS.
The corresponding Travis CI url is https://travis-ci.org/TYPO3/TYPO3.CMS.

When i "slightly" modify the vendor / project name in case of upper and lowercase ("typo3/typo3.cms", "Typo3/Typo3.CMS", ...) the Travis-CI won`t work anymore.
See https://travis-ci.org/typo3/typo3.cms or https://travis-ci.org/Typo3/Typo3.CMS

The output is The repository at Typo3/Typo3.CMS was not found.
On Github every version works. See https://github.com/typo3/typo3.cms or https://github.com/Typo3/Typo3.CMS.

I stumbled upon this bug, because i was typing the travis ci url manually and was confused if i don`t get a match.

As far as i know urls are case insensitive.
My question is: Is this a bug or a feature?

IMO this is a bug, but i like to get your opinion. Do you consider to change this behaviour?

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Feb 8, 2015

See https://tools.ietf.org/html/rfc3986#section-6.2.2 and http://stackoverflow.com/questions/7996919/should-url-be-case-sensitive. GitHub chose to normalize entity names (wisely, perhaps, in order to avoid having multiple organizations with different casing; github vs GitHub vs Github, etc.).

In my opinion, this is not a bug, but this behavior on Travis CI's part is confusing nonetheless.

@joshk

This comment has been minimized.

Copy link
Member

commented Feb 9, 2015

Agree, not strictly a bug, but we could improve this none the less, and shouldn't be hard to either.

I'll talk to the team about this and see what we can do.

@joshk joshk self-assigned this Feb 9, 2015

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Feb 12, 2015

I'm thinking we'd need to add indices on entity names in lower cases, and normalize our queries to lower case. (I'll ignore different collation types.)

@andygrunwald

This comment has been minimized.

Copy link
Author

commented Feb 16, 2015

Would love to see this @BanzaiMan & @joshk.
@BanzaiMan Thx for the ietf link.

@drogus

This comment has been minimized.

Copy link
Member

commented Feb 16, 2015

I think that we could address that with the new API /cc @rkh

The only non-trivial part seems to be adding normalised organisation, user and repository names for a fast lookup in the DB (or maybe just indexing them with LOWER(name), I'm not sure what would be the implications)

@rkh

This comment has been minimized.

Copy link
Member

commented Apr 15, 2015

Index added, v3 API is no longer case sensitive.

@szabgab

This comment has been minimized.

Copy link

commented Nov 24, 2015

The public web interface is still case sensitive. Do I understand correctly that it is now "just a matter of using v3 API?" It would be really nice to have this.

The case I bumped into was
https://travis-ci.org/Manwar/pdf-create/ working and https://travis-ci.org/manwar/pdf-create/ not working.

@drogus

This comment has been minimized.

Copy link
Member

commented Nov 24, 2015

@szabgab unfortunately the public interface doesn't use the API V3 version yet. We plan to switch it, but we don't have any ETA.

@terbach

This comment has been minimized.

Copy link

commented May 22, 2016

Great! Now third party libraries cannot be used if they are mixed with lower- and uppercase? Unacceptable! Thats my problem currently.

@OmgImAlexis

This comment has been minimized.

Copy link

commented Oct 10, 2016

@drogus any updates on this? It'd be nice to have all case urls match since you shouldn't be able to have two projects with the same name but different case.

@stale

This comment has been minimized.

Copy link

commented Apr 14, 2018

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

@stale stale bot added the stale label Apr 14, 2018

@OmgImAlexis

This comment has been minimized.

Copy link

commented Apr 14, 2018

Please don't close this as it's still an issue.

@stale stale bot removed the stale label Apr 14, 2018

@stale

This comment has been minimized.

Copy link

commented Jul 13, 2018

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue in 24 hours. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

@stale stale bot added the stale label Jul 13, 2018

@OmgImAlexis

This comment has been minimized.

Copy link

commented Jul 13, 2018

Please don't close this as it's still an issue.

@Varun-garg

This comment has been minimized.

Copy link

commented Apr 2, 2019

Still facing this issue:

$ travis encrypt "BROWSERSTACK_ACCESS_KEY='$BROWSERSTACK_ACCESS_KEY'"
repository not known to https://api.travis-ci.org/: varun-garg/travis-browserstack-example

I also tried updating the git remote and still wasn't able to get it working. Do you guys really care about the case, if not a fix would be greatly appreciated.

@cotsog cotsog added the important label May 8, 2019

@MariadeAnton

This comment has been minimized.

Copy link
Member

commented May 10, 2019

This is finally fixed! Check out https://changelog.travis-ci.com/repositories'-urls-are-now-case-insensitive!-100772

Please let us know if anything is amiss or if you find something that you'd like to see improved at https://travis-ci.community/

Thank you all!

@MOSSSKITO

This comment has been minimized.

Copy link

commented May 11, 2019

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.