New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications are sent to commit author who does not have write access to repository #4976

Closed
andrewnicols opened this Issue Oct 20, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@andrewnicols

andrewnicols commented Oct 20, 2015

I have a fork of Moodle on my GitHub repository, and I have been trying to get travis-ci.org integration working. All has been going well.

One of my colleagues was trying out my changes on his fork of Moodle. We both have Travis-CI integrated with our own personal forks of Moodle. I do not have write-access to his fork, and he does not have write-access to my fork. They are public repositories so we both have read-access to one-another's code.

However, when I cherry-pick one of his commits, and I push a branch with that commit to my fork, and that commit generates a notification, we have seen that both he and I receive notifications.

According to http://docs.travis-ci.com/user/notifications/#How-is-the-build-email-receiver-determined%3F:
By default, a build email is sent to the committer and the author, but only if they have access to the repository the commit was pushed to. This prevents forks active on Travis CI from notifying the upstream repository’s owners when they’re pushing any upstream changes to their fork.

In this case:

From my understanding, although danpoltawski was the commit author, since he does not have commit access to my repository, he should not receive the e-mail notification.

@joshk

This comment has been minimized.

Show comment
Hide comment
@joshk

joshk Oct 20, 2015

Member

Thank you for creating this issue.

This has been a regression with how we send emails. We have found the code which needs to be changed and will look into this ASAP.

Sorry for the extra emails, and thank you once more for the detail you have provided.

Member

joshk commented Oct 20, 2015

Thank you for creating this issue.

This has been a regression with how we send emails. We have found the code which needs to be changed and will look into this ASAP.

Sorry for the extra emails, and thank you once more for the detail you have provided.

andrewnicols added a commit to andrewnicols/moodle that referenced this issue Oct 21, 2015

MDL-51458 testing: Disable Travis notifications entirely
The Travis-CI service currently over-notifies the upstream repository
owner which can mean that committers without access to a fork of the
repository are notified of failures, and success changes.

Until this issue is addressed, and we are happy with the stability of our
build, we have disabled notification support.

The Travis-CI service problem has been raised in
travis-ci/travis-ci#4976

andrewnicols added a commit to andrewnicols/moodle that referenced this issue Oct 21, 2015

MDL-51458 testing: Disable Travis notifications entirely
The Travis-CI service currently over-notifies the upstream repository
owner which can mean that committers without access to a fork of the
repository are notified of failures, and success changes.

Until this issue is addressed, and we are happy with the stability of our
build, we have disabled notification support.

The Travis-CI service problem has been raised in
travis-ci/travis-ci#4976
@joshk

This comment has been minimized.

Show comment
Hide comment
@joshk

joshk Oct 21, 2015

Member

We have a fix ready and will deploy it shortly.

Member

joshk commented Oct 21, 2015

We have a fix ready and will deploy it shortly.

@mudrd8mz

This comment has been minimized.

Show comment
Hide comment
@mudrd8mz

mudrd8mz Nov 12, 2015

Has this been fixed in prod?

mudrd8mz commented Nov 12, 2015

Has this been fixed in prod?

@joshk

This comment has been minimized.

Show comment
Hide comment
@joshk

joshk Nov 12, 2015

Member

Ah, thanks for reminding me, yes, it has been fixed and deployed to production around 3 weeks ago.

Closing 🎉

Member

joshk commented Nov 12, 2015

Ah, thanks for reminding me, yes, it has been fixed and deployed to production around 3 weeks ago.

Closing 🎉

@joshk joshk closed this Nov 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment