Customized Github Notification by Comment #542

Closed
staabm opened this Issue May 16, 2012 · 10 comments

Comments

Projects
None yet
6 participants
@staabm

staabm commented May 16, 2012

Hi,

first of all, thanks for this great tool! we love it!

Back to business:

The Travisbot atm comments the result of a build in github like:

This pull request passes (merged 3d7b8a1 into 425e9a5).

It would be great if there would be a way to configure in .travis.yml some additional information to be shown.

e.g. in the jQuery project it would be very helpfull to see the diff in filesize before and after the commit.
ATM this is done manually, e.g. in jquery/jquery#776 (comment)

  250723    (-35) jquery.js
   92931    (-21) jquery.min.js
   33106    (-16) jquery.min.js.gz

The idea would be to include a script (in a way like before_script is added) and the output of this script would be included in the comment the travis-bot posts afterwards.
If we think one step further this could also be done for the email notifications, or the notifications in general.

@sarahhodne

This comment has been minimized.

Show comment Hide comment
@sarahhodne

sarahhodne May 16, 2012

Contributor

Hey Markus,

Thanks for the feedback, but I don't really see how this is related to testing?

Contributor

sarahhodne commented May 16, 2012

Hey Markus,

Thanks for the feedback, but I don't really see how this is related to testing?

@dmathieu

This comment has been minimized.

Show comment Hide comment
@dmathieu

dmathieu May 16, 2012

Contributor

Agreed with @dvyjones. This isn't in travis' scope.

Contributor

dmathieu commented May 16, 2012

Agreed with @dvyjones. This isn't in travis' scope.

@sarahhodne sarahhodne closed this May 16, 2012

@staabm

This comment has been minimized.

Show comment Hide comment
@staabm

staabm May 16, 2012

This is not in scope for testing but in scope of a continous integration tool... a CI tool should provide also reports and statistics (code analysis, checkstyle, anti-pattern checks,...) and therefore i would see such an addition as an overall build result.

I don't mean travis to provide the logic for counting and comparing the bytes of the javascript files (rel. to the jQuery example), but to provide a hook which includes a script provided from the travis-ci consumer and take its output back to the comment of the ci bot.

staabm commented May 16, 2012

This is not in scope for testing but in scope of a continous integration tool... a CI tool should provide also reports and statistics (code analysis, checkstyle, anti-pattern checks,...) and therefore i would see such an addition as an overall build result.

I don't mean travis to provide the logic for counting and comparing the bytes of the javascript files (rel. to the jQuery example), but to provide a hook which includes a script provided from the travis-ci consumer and take its output back to the comment of the ci bot.

@sarahhodne

This comment has been minimized.

Show comment Hide comment
@sarahhodne

sarahhodne May 16, 2012

Contributor

/cc @mattmatt @joshk @svenfuchs @rkh - What do you think? Is this in Travis' scope?

Contributor

sarahhodne commented May 16, 2012

/cc @mattmatt @joshk @svenfuchs @rkh - What do you think? Is this in Travis' scope?

@rkh

This comment has been minimized.

Show comment Hide comment
@rkh

rkh May 16, 2012

Owner

We discussed this earlier, sorry for not commenting. We think this is in @travis' scope. Or at least the underlying request of exposing more meta infos and having a (potentially third party) service evaluate these to detect changes, etc. You can do way more than file size with it (ie regression detection). This would be a big project to tackle, and I'm not sure if combining it with @travisbot is something feasible.

Owner

rkh commented May 16, 2012

We discussed this earlier, sorry for not commenting. We think this is in @travis' scope. Or at least the underlying request of exposing more meta infos and having a (potentially third party) service evaluate these to detect changes, etc. You can do way more than file size with it (ie regression detection). This would be a big project to tackle, and I'm not sure if combining it with @travisbot is something feasible.

@rkh rkh reopened this May 16, 2012

@svenfuchs

This comment has been minimized.

Show comment Hide comment
@svenfuchs

svenfuchs May 16, 2012

Owner

should be possible to combine it, i guess. we do have irc message templates, too, and we could use the same approach here.

Owner

svenfuchs commented May 16, 2012

should be possible to combine it, i guess. we do have irc message templates, too, and we could use the same approach here.

@ghost ghost assigned rkh Jun 25, 2012

@3rd-Eden

This comment has been minimized.

Show comment Hide comment
@3rd-Eden

3rd-Eden Aug 3, 2012

Wouldn't it be easier to just trigger some sort of script that is defined in the travis.yml once the test is completed and use the output of that script in the github comment? This ways it's completely up to developers on what kind of info the bot should post.

I mean, third party services are nice and all, but triggering an script on completion isn't rocket science.

3rd-Eden commented Aug 3, 2012

Wouldn't it be easier to just trigger some sort of script that is defined in the travis.yml once the test is completed and use the output of that script in the github comment? This ways it's completely up to developers on what kind of info the bot should post.

I mean, third party services are nice and all, but triggering an script on completion isn't rocket science.

@rkh

This comment has been minimized.

Show comment Hide comment
@rkh

rkh Aug 3, 2012

Owner

We're not 100% sure if we gonna keep commenting. Something awesome is coming to replace it. We could use templates, though, the same way we do for IRC atm.

Owner

rkh commented Aug 3, 2012

We're not 100% sure if we gonna keep commenting. Something awesome is coming to replace it. We could use templates, though, the same way we do for IRC atm.

@3rd-Eden

This comment has been minimized.

Show comment Hide comment
@3rd-Eden

3rd-Eden Aug 4, 2012

Anything is better than nothing :)

On 4 aug. 2012, at 00:23, Konstantin Haasereply@reply.github.com wrote:

We're not 100% sure if we gonna keep commenting. Something awesome is coming to replace it. We could use templates, though, the same way we do for IRC atm.


Reply to this email directly or view it on GitHub:
#542 (comment)

3rd-Eden commented Aug 4, 2012

Anything is better than nothing :)

On 4 aug. 2012, at 00:23, Konstantin Haasereply@reply.github.com wrote:

We're not 100% sure if we gonna keep commenting. Something awesome is coming to replace it. We could use templates, though, the same way we do for IRC atm.


Reply to this email directly or view it on GitHub:
#542 (comment)

@sarahhodne

This comment has been minimized.

Show comment Hide comment
@sarahhodne

sarahhodne Nov 16, 2012

Contributor

@travisbot no longer exists, so there's no GitHub commenting hook any more.

Contributor

sarahhodne commented Nov 16, 2012

@travisbot no longer exists, so there's no GitHub commenting hook any more.

@sarahhodne sarahhodne closed this Nov 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment