[ci skip] can hide builds that should be run #553

Closed
dchelimsky opened this Issue May 20, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@dchelimsky

I pushed a bunch of commits at once, the last of which had "[ci skip]" in the commit message. This caused travis to ignore the whole lot, even though there were commits that didn't have [ci skip] that I would have wanted to run. Now that I know this I'll be careful to push the non-skippable commits first, however it would be really nice if travis could handle this a little more intelligently:

When receiving a commit with [ci skip] in the message, iterate through the parent commits until you reach a) a commit that has already been built, in which case go ahead and ignore the build or b) a commit without [ci skip] that has not been built yet, in which case build it.

@sarahhodne

This comment has been minimized.

Show comment Hide comment
@sarahhodne

sarahhodne May 20, 2012

Contributor

I had this same problem with dvyjones/urk yesterday.

I'm not sure if the github web hook pushes all of the pushed commits, or only the last one. If it pushes all of them, this should be a pretty trivial change.

Contributor

sarahhodne commented May 20, 2012

I had this same problem with dvyjones/urk yesterday.

I'm not sure if the github web hook pushes all of the pushed commits, or only the last one. If it pushes all of them, this should be a pretty trivial change.

@sarahhodne

This comment has been minimized.

Show comment Hide comment
@sarahhodne

sarahhodne May 20, 2012

Contributor

This should be fixed with travis-ci/travis-core#61.

Contributor

sarahhodne commented May 20, 2012

This should be fixed with travis-ci/travis-core#61.

@sarahhodne

This comment has been minimized.

Show comment Hide comment
@sarahhodne

sarahhodne Nov 16, 2012

Contributor

Closing this for now, tracking the issue in travis-ci/travis-core#61 instead.

Contributor

sarahhodne commented Nov 16, 2012

Closing this for now, tracking the issue in travis-ci/travis-core#61 instead.

@sarahhodne sarahhodne closed this Nov 16, 2012

@sarahhodne sarahhodne referenced this issue in travis-ci/travis-core Nov 22, 2012

Merged

Use the last non-skipped commit from GitHub #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment