New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis changes project status to failing after failed pull request #567

Closed
sferik opened this Issue May 26, 2012 · 13 comments

Comments

Projects
None yet
8 participants
@sferik
Contributor

sferik commented May 26, 2012

One of my projects (which has @travisbot for pull requests enabled) had a passing build status before I received this pull request: sferik/t#49

When the pull request's build status changed to failing, my overall project's build status changed to failing, as indicated by the build status icon, even though the pull request had not been merged.

If I look at the Travis build history, the failed build does not appear there. It seems like that same logic could be applied to the "last status on branch" code, but it might be more complicated than that. I'm not very familiar with that area of the code.

@sarahhodne

This comment has been minimized.

Show comment
Hide comment
@sarahhodne

sarahhodne May 26, 2012

Contributor

Probably related to #483.

Contributor

sarahhodne commented May 26, 2012

Probably related to #483.

@svenfuchs

This comment has been minimized.

Show comment
Hide comment
@svenfuchs

svenfuchs May 26, 2012

Member

not sure that's related. pull requests just shouldn't impact the build status at all, no?

Member

svenfuchs commented May 26, 2012

not sure that's related. pull requests just shouldn't impact the build status at all, no?

@sarahhodne

This comment has been minimized.

Show comment
Hide comment
@sarahhodne

sarahhodne May 26, 2012

Contributor

@svenfuchs Well, it seems like the current way of getting the "global" build status for a project is the last finished build, which would explain both of the issues.

Contributor

sarahhodne commented May 26, 2012

@svenfuchs Well, it seems like the current way of getting the "global" build status for a project is the last finished build, which would explain both of the issues.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot May 26, 2012

They shouldn't but do, this was one of the things we wanted to improve later down the line.

On 26/05/2012, at 12:15 PM, Sven Fuchs wrote:

not sure that's related. pull requests just shouldn't impact the build status at all, no?


Reply to this email directly or view it on GitHub:
#567 (comment)

travisbot commented May 26, 2012

They shouldn't but do, this was one of the things we wanted to improve later down the line.

On 26/05/2012, at 12:15 PM, Sven Fuchs wrote:

not sure that's related. pull requests just shouldn't impact the build status at all, no?


Reply to this email directly or view it on GitHub:
#567 (comment)

@sarahhodne

This comment has been minimized.

Show comment
Hide comment
@sarahhodne

sarahhodne May 26, 2012

Contributor

Did @travisbot just go sentient?

Contributor

sarahhodne commented May 26, 2012

Did @travisbot just go sentient?

@certik

This comment has been minimized.

Show comment
Hide comment
@certik

certik Jun 24, 2012

So what should be the proper fix for this issue? The current way is very confusing.

certik commented Jun 24, 2012

So what should be the proper fix for this issue? The current way is very confusing.

@sarahhodne

This comment has been minimized.

Show comment
Hide comment
@sarahhodne

sarahhodne Jun 24, 2012

Contributor

I believe the global build status should be determined by the "master" branch, or a different branch, configurable with the .travis.yml file. It could also just be the latest build in the repository, excluding pull requests.

Contributor

sarahhodne commented Jun 24, 2012

I believe the global build status should be determined by the "master" branch, or a different branch, configurable with the .travis.yml file. It could also just be the latest build in the repository, excluding pull requests.

@asmeurer

This comment has been minimized.

Show comment
Hide comment
@asmeurer

asmeurer Jun 24, 2012

It would be awesome if the browser plugin showed the build status on specific PRs, perhaps in the "so-and-so wants to merge branch x into y" line. In other words, each PR should have its own separate "build status".

asmeurer commented Jun 24, 2012

It would be awesome if the browser plugin showed the build status on specific PRs, perhaps in the "so-and-so wants to merge branch x into y" line. In other words, each PR should have its own separate "build status".

rkh added a commit to travis-ci/travis-core that referenced this issue Jun 25, 2012

@ghost ghost assigned rkh Jun 25, 2012

@bootstraponline

This comment has been minimized.

Show comment
Hide comment
@bootstraponline

bootstraponline Jul 19, 2012

Is this fixed now?

bootstraponline commented Jul 19, 2012

Is this fixed now?

@svenfuchs

This comment has been minimized.

Show comment
Hide comment
@svenfuchs

svenfuchs Jul 19, 2012

Member

i @rkh's commit should have fixed it. could someone verify?

Member

svenfuchs commented Jul 19, 2012

i @rkh's commit should have fixed it. could someone verify?

@rkh

This comment has been minimized.

Show comment
Hide comment
@rkh

rkh Jul 19, 2012

Member

There still seems to be something broken related to this, see http://travis-ci.org/#!/emberjs/ember.js/builds/1901443 - it's being treated as the "current build".

Member

rkh commented Jul 19, 2012

There still seems to be something broken related to this, see http://travis-ci.org/#!/emberjs/ember.js/builds/1901443 - it's being treated as the "current build".

@rkh

This comment has been minimized.

Show comment
Hide comment
@rkh

rkh Jul 19, 2012

Member

Oh, no, it's working:

Member

rkh commented Jul 19, 2012

Oh, no, it's working:

@rkh rkh closed this Jul 19, 2012

@certik

This comment has been minimized.

Show comment
Hide comment
@certik

certik Jul 22, 2012

Thanks for fixing it! It looks like it is working for us too.

certik commented Jul 22, 2012

Thanks for fixing it! It looks like it is working for us too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment