New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading python mock module to 1.3.0 #5849

Closed
alexm opened this Issue Apr 1, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@alexm
Copy link

alexm commented Apr 1, 2016

Some days ago I found that the build failed with the infamous message Killed after a couple of minutes.

My first thought was that there should be some limits in place that stopped the build for any reason, so I added ulimit -a to the build steps to figure out what it was. Since I couldn't find the reason, I looked for a way to run the docker image on my box and eventually found it (thanks!).

It didn't take me much time to figure out that I was using python mock module 1.3.0 in my box and that the one provided by the worker is older, so requesting that version in requirements.txt saved the day.

The part of mock module that is triggering the Killed message seems to be the mock_open call, but I'm not really sure. Anyway, I thought that other people may suffer the same fate and I just wanted to let you know, just in case you would consider upgrading python mock module to 1.3.0.

Thanks for this wonderful service!

@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Apr 3, 2016

Until the build image is updated, the library is not going to be updated for pre-installed Python runtimes. We have plans to address the build image update issue, but there is no ETA. Perhaps if you specify a newer Python version that is not pre-installed (e.g., 2.7.11), mock might be recent enough for you.

I'm sorry to say, though, if you need a particular version of mock library, you need to specify that in your requirements.txt. pip resolved the dependency correctly, given the constraints you provided.

@alexm

This comment has been minimized.

Copy link
Author

alexm commented Apr 10, 2016

As I already mentioned, setting mock>=1.3.0 in requirements did the trick for me. I just wanted to let you know in case more people have issues with the mock version provided by the build image.

@mcrute

This comment has been minimized.

Copy link

mcrute commented Jun 19, 2017

According to the docs nose, pytest and mock are all installed in the default python image. I was able to work around it by adding a pip install -U to my before_script config but it would be less surprising (and arguably more correct) to remove these from the image and force projects to model them correctly as dependencies.

@stale

This comment has been minimized.

Copy link

stale bot commented Apr 13, 2018

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

@stale stale bot added the stale label Apr 13, 2018

@stale stale bot closed this Apr 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment