Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Rebased pull requests do not trigger new builds #719

Closed
devoid opened this Issue Oct 9, 2012 · 7 comments

Comments

Projects
None yet
4 participants

devoid commented Oct 9, 2012

I hope this is the right place for this issue...

If I initiate a pull request then rebase the commits, new builds are not triggered. In fact no additional commits are tested on that pull request.

Owner

joshk commented Oct 9, 2012

Oh, that is interesting, @rkh you might be best to answer this :)

On 9/10/2012, at 8:25 PM, Scott Devoid wrote:

I hope this is the right place for this issue...

If I initiate a pull request then rebase the commits, new builds are not triggered. In fact no additional commits are tested on that pull request.


Reply to this email directly or view it on GitHub.

Owner

rkh commented Oct 9, 2012

Strange, this should work. @devoid do you have a link to a particular pull request?

I'll try to reproduce this when I'm back in Berlin.

devoid commented Oct 9, 2012

Hmm... it looks like it started running tests on some of my commits. Is there a variable delay between pushing a commit to Github and Travis CI queuing the build? Do the "lights turn yellow" when the build starts or when it's queued?

Owner

rkh commented Oct 9, 2012

They turn yellow when the build starts. Builds should show up in the queue on the right sidebar.

dulaccc commented Mar 6, 2013

I see that this issue is still open, so I can provide my use case where rebased commit didn't trigger new builds on its pull request. But I found that the travis builds were run.
So it seems to only be a display error.

Hope it helps

devoid commented Mar 11, 2013

Yes, I think this is a bug with how Github handles things. Thank you for
looking into it as well.
~ Scott

On Wed, Mar 6, 2013 at 4:15 PM, Pierre Dulac notifications@github.comwrote:

I see that this issue is still open, so I can provide my use case where rebased
commithttps://github.com/tomchristie/django-rest-framework/pull/693#commits-pushed-6f57641didn't trigger new builds on its pull
request tomchristie/django-rest-framework#693.
But I found that the travis buildshttps://travis-ci.org/tomchristie/django-rest-framework/builds/5296716were run.
So it seems to only be a display error.

Hope it helps


Reply to this email directly or view it on GitHubhttps://github.com/travis-ci/travis-ci/issues/719#issuecomment-14529805
.

Owner

joshk commented Jun 28, 2013

Closing as this does not seem to be a Travis issue. Thanks for reporting the issue :)

@joshk joshk closed this Jun 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment