Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node.js on ChakraCore #8017

Closed
xzyfer opened this issue Jul 3, 2017 · 9 comments

Comments

Projects
None yet
3 participants
@xzyfer
Copy link

commented Jul 3, 2017

Add support for node-chakracore. NVM can be used to install nightlys from https://nodejs.org/download/chakracore-nightly/ as outlined in nvm-sh/nvm#1067. However the stable builds are not yet hosted on nodejs.org, in which case there is not yet a reliable solution see https://github.com/jasongin/nvs/blob/master/doc/CI.md#github-api-tokens.

This will help adoption, and stress testing of node-chakracore.

Related
appveyor/ci#1148
nodejs/node-chakracore#136
sass/node-sass#1776
sass/node-sass#1777

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Jul 3, 2017

We should wait until nvm supports it fully. As @ljharb said nvm-sh/nvm#1067 (comment), whatever we do now is likely to be incompatible with any possible future support by nvm.

@BanzaiMan BanzaiMan added the node.js label Jul 3, 2017

@xzyfer

This comment has been minimized.

Copy link
Author

commented Jul 4, 2017

I opened this issue in part because the tone of that, and previous discussions, suggest little interesting in supporting other Node builds. Where as newer alternatives like nvs consider alternate builds as first class as well as being x-platform.

I have requested clarification from @ljharb on how to proceed with adding support. He previously expressed concerns around low usage when jxcore support was requested. However without support from services like Travis CI and AppVeyor adoption among package maintainers is being hampered.

By adding support for ChakraCore you're enabling adoption, and experimentation. It doesn't seem fair to leave that choice in the hands of a package maintainer. Sure users can work around this limitation but it's a non-trivial obstacle, and a sign of low-confidence.

It's also worth noting that other popular version manages have refused added support for ChakraCore on similar grounds.

@xzyfer

This comment has been minimized.

Copy link
Author

commented Jul 4, 2017

Further clarification from nvm suggests a feature is in the works to add a supported workaround.

@stale

This comment has been minimized.

Copy link

commented Apr 13, 2018

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

@stale stale bot added the stale label Apr 13, 2018

@strugee

This comment has been minimized.

Copy link

commented Apr 13, 2018

@Stale it is

@stale stale bot removed the stale label Apr 13, 2018

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Apr 13, 2018

I don’t think this is something we will work on to fix, but rather rely on nvm to provide.

@stale

This comment has been minimized.

Copy link

commented Jul 12, 2018

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue in 24 hours. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

@stale stale bot added the stale label Jul 12, 2018

@xzyfer

This comment has been minimized.

Copy link
Author

commented Jul 13, 2018

This feature is coming to nvm - nvm-sh/nvm#1828

@stale stale bot removed the stale label Jul 13, 2018

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Oct 2, 2018

Closing as an upstream issue.

@BanzaiMan BanzaiMan closed this Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.