Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add PHP 7.3 images #9717

Closed
Majkl578 opened this issue Jun 7, 2018 · 53 comments

Comments

@Majkl578
Copy link

commented Jun 7, 2018

PHP 7.3.0alpha1 was released today: http://news.php.net/php.internals/102198

Please consider preparing PHP 7.3 image so it can be used for testing once 7.3 reaches beta.

Timetable for 7.3 can be found here. PHP 7.3 should be branched on July 17 and master will become 7.4 (thus should become nightly on Travis).

Thanks!

@mlocati

This comment has been minimized.

Copy link

commented Jun 21, 2018

And today they released 7.3.0alpha2: http://php.net/archive/2018.php#id2018-06-21-1

@emirb

This comment has been minimized.

Copy link

commented Jul 25, 2018

7.3.0alpha4 also released in the meantime

@BenMorel

This comment has been minimized.

Copy link

commented Jul 31, 2018

PHP 7.3.0 is now beta: http://php.net/archive/2018.php#id2018-08-02-1
Any ETA on this?

@Majkl578

This comment has been minimized.

Copy link
Author

commented Aug 2, 2018

Beta 1 is now officially released: http://news.php.net/php.internals/103024

@BanzaiMan Can you please give us any ETA? Thanks!

@Majkl578 Majkl578 changed the title Please add PHP 7.3 alpha images Please add PHP 7.3 images Aug 2, 2018

@BenMorel

This comment has been minimized.

Copy link

commented Aug 14, 2018

Beta 2 tagged today.

@localheinz

This comment has been minimized.

@mlocati

This comment has been minimized.

Copy link

commented Aug 20, 2018

Just for reference, here's the list of estimated release dates of PHP 7.3: https://wiki.php.net/todo/php73

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Sep 7, 2018

We will take a look some time next week. Sorry for the delay.

@BanzaiMan BanzaiMan added the php label Sep 7, 2018

@BanzaiMan BanzaiMan self-assigned this Sep 7, 2018

@Majkl578

This comment has been minimized.

Copy link
Author

commented Sep 7, 2018

@BanzaiMan Thanks. Note that RC1 is coming next thursday (usually tagged on Tue/Wed) so it would be nice to include this release candidate. 😊

@khs1994 khs1994 referenced this issue Sep 11, 2018
@Majkl578

This comment has been minimized.

Copy link
Author

commented Sep 12, 2018

7.3.0RC1 tagged

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

For 7.3.0RC1, we are waiting for php-build/php-build#527 to be merged.

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

travis-ci/travis-nightly-builder@264a8f5 adds 7.3snapshot.

@Majkl578

This comment has been minimized.

Copy link
Author

commented Sep 12, 2018

Thanks! Can we also expect the 7.3 alias? 🙏
PHP 7.2 got its 7.2 alias for 7.2.0beta1: #7989 (comment)

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

Trusty and Precise can't build 7.3 because libzip is too old https://travis-ci.org/travis-ci/php-src-builder/jobs/427827063#L942

and the Xenial build has an compilation error: https://travis-ci.org/travis-ci/php-src-builder/jobs/427827062.

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

Maybe RC1 at least compiles on Xenail. We shall see.

@sodabrew

This comment has been minimized.

Copy link

commented Sep 13, 2018

The build failure is in the ssh2 module, which does not yet have a PHP 7.3-compatible release: https://github.com/php/pecl-networking-ssh2/commits/master

This is a chicken-and-egg situation because the ssh2 module tests on Travis CI: https://github.com/php/pecl-networking-ssh2/blob/master/.travis.yml

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Sep 13, 2018

Disabling ssh2 on 7.3 should suffice, then, but 7.3 will only be available for Xenial with sudo: required. Once ssh2 is in good shape, we can re-enable it.

@Majkl578

This comment has been minimized.

Copy link
Author

commented Sep 13, 2018

7.3 will only be available for Xenial with sudo: required.

I can imagine this will be a problem in long-term. People will switch their configurations to Xenial (config-wide dist: xenial) + sudo: required in order to also run their tests on PHP 7.3.
Xenial dist isn't documented either: https://docs.travis-ci.com/user/reference/overview/#stq=xenial&stp=1

svn2github pushed a commit to svn2github/wp-svn-2-git that referenced this issue Oct 5, 2018
jorbin
Build/Test Tools: Add PHP7.3 RC1 to the build matrix
Currently, we need to do some extra steps to run 7.3, but this will help us with testing compatibility.

See: travis-ci/travis-ci#9717

See #44771.

Built from https://develop.svn.wordpress.org/trunk@43673


git-svn-id: http://core.svn.wordpress.org/trunk@43502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento pushed a commit to WordPress/wordpress-develop that referenced this issue Oct 10, 2018
Build/Test Tools: Add PHP7.3 RC1 to the build matrix
Currently, we need to do some extra steps to run 7.3, but this will help us with testing compatibility.

See: travis-ci/travis-ci#9717

See #44771.

Merges [43673] to the 5.0 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/5.0@43692 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this issue Oct 10, 2018
Build/Test Tools: Add PHP7.3 RC1 to the build matrix
Currently, we need to do some extra steps to run 7.3, but this will help us with testing compatibility.

See: travis-ci/travis-ci#9717

See #44771.

Merges [43673] to the 5.0 branch.

Built from https://develop.svn.wordpress.org/branches/5.0@43692


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this issue Oct 10, 2018
Build/Test Tools: Add PHP7.3 RC1 to the build matrix
Currently, we need to do some extra steps to run 7.3, but this will help us with testing compatibility.

See: travis-ci/travis-ci#9717

See #44771.

Merges [43673] to the 5.0 branch.

Built from https://develop.svn.wordpress.org/branches/5.0@43692


git-svn-id: https://core.svn.wordpress.org/branches/5.0@43521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@Majkl578

This comment has been minimized.

Copy link
Author

commented Oct 13, 2018

PHP 7.3 is now available on Trusty and Precise (7.3.0RC3 aliased to 7.3) in non-sudo mode.

libzip issue handled in travis-ci/php-src-builder#23

PHP build: https://travis-ci.org/travis-ci/php-src-builder/builds/440768084
reference consumer PR with 7.3 enabled on Trusty: doctrine/dbal#3323
reference consumer build with 7.3 enabled on Trusty: https://travis-ci.org/doctrine/dbal/builds/441068343

There is an unrelated build problem with 7.3 on Xenial, will need to be debugged separately.

koriym added a commit to koriym/BEAR.Resource that referenced this issue Oct 15, 2018
koriym added a commit to koriym/BEAR.Sunday that referenced this issue Oct 15, 2018
@makamo makamo referenced this issue Oct 16, 2018
1 of 3 tasks complete
miya0001 pushed a commit to cjk4wp/wordpress that referenced this issue Oct 25, 2018
johnbillion
Build/Test Tools: Add PHP7.3 RC1 to the build matrix
Currently, we need to do some extra steps to run 7.3, but this will help us with testing compatibility.

See: travis-ci/travis-ci#9717

See #44771.

Merges [43673] to the 5.0 branch.


git-svn-id: http://develop.svn.wordpress.org/branches/5.0@43692 602fd350-edb4-49c9-b593-d223f7449a82
pretzlaw pushed a commit to pretzlaw/wp-integration-test that referenced this issue Oct 27, 2018
Pretzlaw
QA: Pre-Test against PHP 7.3
Travis-CI added a PHP 7.3 build.
Now we can test things against this version too.

- Allowed to fail until better code coverage is given.
- see travis-ci/travis-ci#9717 (comment)
Jalle19 added a commit to digiaonline/graphql-php that referenced this issue Nov 8, 2018
@ntwb

This comment has been minimized.

Copy link

commented Nov 27, 2018

There is an unrelated build problem with 7.3 on Xenial, will need to be debugged separately.

I see that issue is now closed, but PHP 7.3 is still unavailable on Xenial?

Build system information
Build language: php
Build group: stable
Build dist: xenial
Build id: 92643339
Job id: 161004225
Runtime kernel version: 4.15.0-1023-gcp
travis-build version: 206e3514d
...
...
...
0.02s$ phpenv global 7.3 2>/dev/null
7.3 is not pre-installed; installing
Downloading archive: https://s3.amazonaws.com/travis-php-archives/binaries/ubuntu/16.04/x86_64/php-7.3.tar.bz2
0.31s$ curl -s -o archive.tar.bz2 $archive_url && tar xjf archive.tar.bz2 --directory /
bzip2: (stdin) is not a bzip2 file.
tar: Child returned status 2
tar: Error is not recoverable: exiting now
0.00s0.02s$ phpenv global 7.3
rbenv: version `7.3' not installed
The command "phpenv global 7.3" failed and exited with 1 during .
Your build has been stopped.
@ADmad

This comment has been minimized.

Copy link

commented Nov 27, 2018

I see that issue is now closed...

The issue is still open 🙂.

@ntwb

This comment has been minimized.

Copy link

commented Nov 27, 2018

The linked issue is a pull request that has been merged: travis-ci/php-src-builder#23 (comment)

@Majkl578

This comment has been minimized.

Copy link
Author

commented Nov 27, 2018

I spent some time reproducing the Xenial build failure (in travis-ci/php-src-builder#23 (comment)) with no luck. I decided to abandon the effort since I have no plans on using Xenial as it's undocumented and not stable anyway. Sorry. Use Trusty if you need PHP 7.3.

ramazantufekci pushed a commit to ramazantufekci/github-move that referenced this issue Nov 28, 2018
johnbillion
Build/Test Tools: Add PHP7.3 RC1 to the build matrix
Currently, we need to do some extra steps to run 7.3, but this will help us with testing compatibility.

See: travis-ci/travis-ci#9717

See #44771.

Merges [43673] to the 5.0 branch.

Built from https://develop.svn.wordpress.org/branches/5.0@43692
@DrTorte

This comment has been minimized.

Copy link
Contributor

commented Dec 5, 2018

Hello,

We're moving our community communications to the Travis CI Community Forum and will no longer be supporting GitHub issues. If this hasn't been solved, please go ahead and create a new thread on the Forum and we'll be better able to help you there. We're looking forward to seeing you there.

If you need support, you can reach our support team here: support@travis-ci.com.

Thanks and happy building!

@DrTorte DrTorte closed this Dec 5, 2018

@BenMorel

This comment has been minimized.

Copy link

commented Dec 5, 2018

Here: https://travis-ci.community/t/please-add-php-7-3-on-xenial/1238

For what it's worth, it's really a pity to see you move from highly usable GitHub issue tracker to a regular forum, that's much less readable & practical for us to use.

aaronjorbin added a commit to aaronjorbin/wordpress-develop that referenced this issue Feb 20, 2019
Build/Test Tools: Add PHP7.3 RC1 to the build matrix
Currently, we need to do some extra steps to run 7.3, but this will help us with testing compatibility.

See: travis-ci/travis-ci#9717

See #44771.


git-svn-id: https://develop.svn.wordpress.org/trunk@43673 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.