Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build status icon #974

Closed
KOLANICH opened this issue Mar 10, 2013 · 4 comments
Closed

Build status icon #974

KOLANICH opened this issue Mar 10, 2013 · 4 comments

Comments

@KOLANICH
Copy link

Hello, I have an idea.
Including a build status icon in readme can make troubles to forkers and pullers.
The solution is to make icon accessible via https://travis-ci.org/buildStatus/[imageType].png ,
where [imageType] is name of a variation of the image (size, style,etc).
The repo is determined using Referer header.

@KOLANICH
Copy link
Author

Place this issue to the right place and remove https://github.com/travis-ci/travis-ci.github.com/issues/230

@rkh
Copy link
Contributor

rkh commented Mar 10, 2013

READMEs are often served via SSL, in which case the browser won't include a Referer.

@KOLANICH
Copy link
Author

If both sites have been accessed via https browser should send Referer header ... and it really sends.

@BanzaiMan
Copy link
Contributor

I don't think Referer: header is reliable enough to be used in this way. If there is a better way, we can discuss its merits.

For now, I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants