Update sbt-extras user_home_basedir #150

Closed
rockymadden opened this Issue Feb 3, 2013 · 14 comments

Projects

None yet

3 participants

Contributor

The file referred to in d0a5404#ci_environment/sbt/attributes/default.rb should be updated and then include the changes in the yet unmerged pull request by @gildegoma paulp/sbt-extras#36.

This will then allow for 0.12.2 to be set as the default (rather than the RC). Scala builds referencing 0.12.2 right now must download it each time.

Owner
joshk commented Feb 3, 2013

Sorry, I am a bit slow, can you explain what needs to change in the cookbooks?

Contributor

I was going to do the the pull request but got stuck when there was a hard dependency on an external to Travis repo: https://github.com/gildegoma/sbt-extras/raw/63e8d0f7a6bd25c81f59befc040e6eb3b35e2501/sbt

These two lines need to be modified: https://github.com/travis-ci/travis-cookbooks/blob/master/ci_environment/sbt/attributes/default.rb#L11-13

@gildegoma will first have to update his fork. Then the version will need to be set to 0.12.2.

Owner
joshk commented Feb 3, 2013

Ok, so how do we fix that?

On 3/02/2013, at 5:31 PM, Rocky Madden notifications@github.com wrote:

Just so it's clear. Nothing is broke, however currently each new Scala SBT run will download it.


Reply to this email directly or view it on GitHub.

Contributor

I stand corrected, it only downloads in certain circumstances. However, 0.12.2 should still be made available (and not the RC). :)


I can do it myself if you are okay having a hard dependency on a repo of my own (you already have one to @gildegoma).

What needs to happen:

  1. Make a new fork of: https://github.com/paulp/sbt-extras
  2. Because Travis is dependent upon a pull request that has not been merged into sbt-extras, it will need to be added manually: paulp/sbt-extras#36
  3. Update URL in https://github.com/travis-ci/travis-cookbooks/blob/master/ci_environment/sbt/attributes/default.rb#L11
  4. Update version in https://github.com/travis-ci/travis-cookbooks/blob/master/ci_environment/sbt/attributes/default.rb#L13

Updated for clarity

Contributor

Hopefully that makes sense. I apologize if I am not being clear.

Owner
joshk commented Feb 3, 2013

Create a PR and we can discuss it further there :)

On 3/02/2013, at 5:46 PM, Rocky Madden notifications@github.com wrote:

Hopefully that makes sense. I apologize if I am not being clear.


Reply to this email directly or view it on GitHub.

Contributor

Sounds good! I'll submit it tomorrow, as it's getting late here (as you can tell by my rambling). Cheers!

@rockymadden rockymadden closed this Feb 3, 2013
Member

Hey @rockymadden! Thanks for working on that point :)

Expecting such situation, I already prepared a branch to maintain the updates of sbt-extras script.
The idea is to refer to the latest verison from the sbt (sbt-extras) travis-cookbook: https://raw.github.com/gildegoma/sbt-extras/travis-ci/sbt

I have no time left now to update the travis cookbook and the sbt-extras fork. I added you as member of gildegoma/sbt-extras repo so you can directly update this travis-ci branch. Could you please:

Next steps (not to forget): if paulp/sbt-extras#36 is still not accepted, maybe fork the gildegoma/sbt-extras to travis-repos/sbt-extras (or travis/sbt-extras), in order to make things clearer and grant more people for future updates.

Let me know if you're ok or not with poposed "procedure" :)

Contributor

Sounds good, happy to do so. I was going to do so yesterday on a new fork of my own, but didn't have the time. Doing so on your fork is better. :)

Contributor

A little slammed this week between work, volunteering, and a Scala conference. I'll get it done as soon as I can. Thanks for the add!

Member

Issue reopened, fixing commit is coming quite soon...

@gildegoma gildegoma reopened this Feb 16, 2013
@gildegoma gildegoma closed this in 1382526 Feb 16, 2013
Member

Hi @rockymadden ! Having some available time to update that issue, I take it on my own. I hope it's okay for you. The cookbook now refers to the head of 'travis-ci' branch of my sbt-extras fork, to reduce the need of change in travis-cookbooks itself.
Thanks again for all your valuable inputs and feel free to merge more sbt-extras changes into https://github.com/gildegoma/sbt-extras/tree/travis-ci branch. In such case, it would be nice to update gildegoma/sbt-extras#1 for notification.

Contributor

Yep, no worries. Sorry I wasn't able to get before you. Life is a bit crazy these days (own business, baby, puppies, etc).

Member

@rockymadden sorry for so late answer! Same for me, not so much time to contribute these days. Thanks a lot again for the sbt tuning settings you provided, in particular you made scalaz project again capable with Scala 2.10.0 (see scalaz/scalaz#247 (comment))
We keep in touch for further updates...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment