Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ShellCheck from v0.6.0 to v0.7.0 #1068

Merged
merged 1 commit into from Jan 8, 2020

Conversation

@ljharb
ljharb approved these changes Jan 3, 2020
@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Jan 3, 2020

Looks like there might be rubocop failures on master that need fixing first.

@PeterDaveHello

This comment has been minimized.

Copy link
Contributor Author

PeterDaveHello commented Jan 5, 2020

hmmm, I'm not sure if those errors are related to the changes here 🤔

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Jan 5, 2020

They’re not; they’re from a dep update, but looks like #1069 can address it.

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Jan 7, 2020

@PeterDaveHello please rebase this and it should pass

@PeterDaveHello PeterDaveHello force-pushed the PeterDaveHello:update-shellcheck-v0.7.0 branch from 021d6d6 to 5603ae6 Jan 8, 2020
@PeterDaveHello

This comment has been minimized.

Copy link
Contributor Author

PeterDaveHello commented Jan 8, 2020

Sure, thanks.

@ljharb ljharb merged commit e82c187 into travis-ci:master Jan 8, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@PeterDaveHello PeterDaveHello deleted the PeterDaveHello:update-shellcheck-v0.7.0 branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.