Ensure an SSL key is still created lazily #22

Merged
merged 3 commits into from Mar 19, 2012

Conversation

Projects
None yet
4 participants
Owner

roidrage commented Mar 19, 2012

This ensures that repositories do get an ssl key if they don't have one yet, but also makes sure a validation error doesn't fail it and reloads the association instead.

Owner

rkh commented on 493b36e Mar 19, 2012

:)

Contributor

KL-7 replied Mar 19, 2012

why?

Owner

rkh replied Mar 19, 2012

I told him to either do alias associated_key key or alias_method :associated_key, :key, not alias :associated_key :key.

Contributor

KL-7 replied Mar 19, 2012

@rkh, simply because it's two characters less or there is some significant difference between passing symbols or not to alias? Btw, I finally checked out the difference between alias_method method and alias keyword. According to this article I'd say alias_method is better in most cases.

Owner

rkh replied Mar 19, 2012

@KL-7 using alias with symbols is just wrong. it gives the illusion of alias taking arguments (i.e. that you could pass variables to it).

joshk added a commit that referenced this pull request Mar 19, 2012

Merge pull request #22 from travis-ci/sslkey-on-create
Ensure an SSL key is still created lazily

@joshk joshk merged commit 837b988 into master Mar 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment