This repository has been archived by the owner. It is now read-only.

[WIP] Only denormalize a build if it's the most recent #318

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@Aaron1011
Contributor

Aaron1011 commented Dec 28, 2013

Don't merge this yet.

Show outdated Hide outdated lib/travis/model/build/states.rb Outdated
Show outdated Hide outdated lib/travis/model/build/states.rb Outdated
@Aaron1011

This comment has been minimized.

Show comment
Hide comment
@Aaron1011

Aaron1011 Jan 3, 2014

Contributor

@henrikhodne: Does this look good?

Contributor

Aaron1011 commented Jan 3, 2014

@henrikhodne: Does this look good?

@sarahhodne

This comment has been minimized.

Show comment
Hide comment
@sarahhodne

sarahhodne Jan 3, 2014

Contributor

I think this is correct and makes sense, but I'd like for someone else to look over this as well.

Contributor

sarahhodne commented Jan 3, 2014

I think this is correct and makes sense, but I'd like for someone else to look over this as well.

@Aaron1011

This comment has been minimized.

Show comment
Hide comment
@Aaron1011

Aaron1011 Jan 3, 2014

Contributor

@henrikhodne: Actually, I need to fix PR #319 first.

Contributor

Aaron1011 commented Jan 3, 2014

@henrikhodne: Actually, I need to fix PR #319 first.

@Aaron1011

This comment has been minimized.

Show comment
Hide comment
@Aaron1011

Aaron1011 Jan 11, 2014

Contributor

@henrikhodne: I've fixed the other PR now. I think it's ready to merge.

Contributor

Aaron1011 commented Jan 11, 2014

@henrikhodne: I've fixed the other PR now. I think it's ready to merge.

Show outdated Hide outdated lib/travis/model/build.rb Outdated
Show outdated Hide outdated lib/travis/model/build.rb Outdated
Show outdated Hide outdated lib/travis/model/build.rb Outdated
@sarahhodne

This comment has been minimized.

Show comment
Hide comment
@sarahhodne

sarahhodne Jan 26, 2014

Contributor

@Aaron1011 Awesome, thank you. I fixed the specs and merged this in 68c1088.

Contributor

sarahhodne commented Jan 26, 2014

@Aaron1011 Awesome, thank you. I fixed the specs and merged this in 68c1088.

@@ -22,7 +22,7 @@ def denormalize(event, *args)
}
def denormalize?(event)
DENORMALIZE.key?(event)
DENORMALIZE.key?(event) && last_build_on_default_branch?

This comment has been minimized.

@joshk

joshk Jan 29, 2014

Member

@henrikhodne does this mean we only denormalize builds on the default branch? This is going to be confusing in the UI as a pusher event will come through for a PR build and update the side bar, but then if you refresh you won't see that update as the build was not denormalized.

@joshk

joshk Jan 29, 2014

Member

@henrikhodne does this mean we only denormalize builds on the default branch? This is going to be confusing in the UI as a pusher event will come through for a PR build and update the side bar, but then if you refresh you won't see that update as the build was not denormalized.

This comment has been minimized.

@Aaron1011

Aaron1011 Jan 30, 2014

Contributor

@joshk: Where does travis-web update the sidebar? Looking at the receive method, it doesn't seem to do much when a build:started event comes in.

@Aaron1011

Aaron1011 Jan 30, 2014

Contributor

@joshk: Where does travis-web update the sidebar? Looking at the receive method, it doesn't seem to do much when a build:started event comes in.

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Jan 29, 2014

Member

I reverted this commit. See 183d8f1.

Member

BanzaiMan commented Jan 29, 2014

I reverted this commit. See 183d8f1.

@BanzaiMan BanzaiMan reopened this Jan 29, 2014

@sarahhodne

This comment has been minimized.

Show comment
Hide comment
@sarahhodne

sarahhodne Jan 29, 2014

Contributor

So the denormalization logic is in travis-web as well?

Contributor

sarahhodne commented Jan 29, 2014

So the denormalization logic is in travis-web as well?

@joshk

This comment has been minimized.

Show comment
Hide comment
@joshk

joshk Jan 29, 2014

Member

no, but it is partially tied to the UI. This has been the issue with our UI for a long time, and why we looked at changes which then became labs.

Member

joshk commented Jan 29, 2014

no, but it is partially tied to the UI. This has been the issue with our UI for a long time, and why we looked at changes which then became labs.

@roidrage

This comment has been minimized.

Show comment
Hide comment
@roidrage

roidrage Jun 17, 2014

Member

How could we proceed here? There'd be changes required in travis-web as well?

Member

roidrage commented Jun 17, 2014

How could we proceed here? There'd be changes required in travis-web as well?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.