Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication #10

Open
sarahhodne opened this issue Nov 16, 2012 · 2 comments
Open

Authentication #10

sarahhodne opened this issue Nov 16, 2012 · 2 comments

Comments

@sarahhodne
Copy link
Contributor

So, OAuth authentication isn't really implemented yet in the API, so this is the way I think it's going to work.

  1. You hit "Sign in" in the app
  2. The app authenticates with GitHub somehow (see below).
  3. The app authenticates with the Travis API through the /auth/github endpoint.
  4. Profit! (Or something) 💵

The GitHub login can be done in many ways, and I haven't quite decided which way I like the best.

  • We could open the user's browser to the GitHub login page (or it'll just ask you to approve the Travis Mac App otherwise).
  • We could make a smaller web view of some sorts.
  • We could make our custom login form and then log in to GitHub with HTTP Basic authentication and get a token from that.

So, what option do you think is the best? And what features do you want to see once we have authentication. This is what I've thought of so far:

  • Automatically add your repos to the watch list (<yourusername>/*).
  • Trigger rebuilds for repos you can rebuild.
@ghost ghost assigned sarahhodne Nov 16, 2012
@rkh
Copy link

rkh commented Nov 16, 2012

It would also be possible to start a local web app running travis-sso, as localhost is whitelisted. Though I'm not sure if we'll keep it that way.

Alternative would also be to implement OAuth app registration for travis-api. ;)

@sarahhodne
Copy link
Contributor Author

I'll make sure to keep the authentication logic separate so we can swap it later should that be something we want.

@sarahhodne sarahhodne removed their assignment Mar 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants