Remove config injections via initializer (#1569)

* Update package-lock.json

* Remove config injections from routes

* Remove injection from components

Still need to import the config to make sure that it is available in the component templates. Then had to silence the ESLint warnings

* Remove controller injections

* Remove config initializer

* Add missing config references in components

This was breaking certain links/other functionality

app/components/header-links.js

@@ -1,15 +1,19 @@
 /* global HS */
+/* eslint no-unused-vars: ["error", { "varsIgnorePattern": "config" }]*/
 
 import Ember from 'ember';
 import Component from '@ember/component';
 import { htmlSafe } from '@ember/string';
 import { service } from 'ember-decorators/service';
 import { action, computed } from 'ember-decorators/object';
 import { alias } from 'ember-decorators/object/computed';
+import config from 'travis/config/environment';
 
 export default Component.extend({
   tagName: '',
 
+  config,
+
   @service auth: null,
   @service features: null,
   @service externalLinks: null,

app/components/page-footer.js

@@ -1,8 +1,14 @@
-import { inject as service } from '@ember/service';
+/* eslint no-unused-vars: ["error", { "varsIgnorePattern": "config" }]*/
+
 import Component from '@ember/component';
+import { service } from 'ember-decorators/service';
+import config from 'travis/config/environment';
 
 export default Component.extend({
-  features: service(),
+  @service features: null,
+
+  config,
+
   tagName: 'footer',
   classNames: ['footer']
 });

app/components/repository-sidebar.js

@@ -7,6 +7,7 @@ import { task } from 'ember-concurrency';
 import { computed } from 'ember-decorators/object';
 import { alias } from 'ember-decorators/object/computed';
 import { service } from 'ember-decorators/service';
+import config from 'travis/config/environment';
 
 export default Component.extend({
   @service tabStates: null,
@@ -42,7 +43,7 @@ export default Component.extend({
     }
 
     if (!Ember.testing) {
-      Visibility.every(this.config.intervals.updateTimes, () => {
+      Visibility.every(config.intervals.updateTimes, () => {
         const callback = (record) => record.get('currentBuild');
         const withCurrentBuild = this.get('_data').filter(callback).map(callback);
         this.get('updateTimesService').push(withCurrentBuild);

app/components/x-tracer.js

@@ -1,14 +1,18 @@
 /* global TravisTracer, window */
+/* eslint no-unused-vars: ["error", { "varsIgnorePattern": "config" }]*/
 
 import Ember from 'ember';
 import Component from '@ember/component';
 import { action } from 'ember-decorators/object';
+import config from 'travis/config/environment';
 
 export default Component.extend({
   tagName: 'div',
   panelIsOpen: false,
   requests: [],
 
+  config,
+
   init() {
     this._super(...arguments);
 

app/controllers/account.js

@@ -9,6 +9,8 @@ export default Controller.extend({
   @service externalLinks: null,
   @service features: null,
 
+  config,
+
   @alias('auth.currentUser') user: null,
 
   @action

app/controllers/accounts.js

@@ -0,0 +1,8 @@
+/* eslint no-unused-vars: ["error", { "varsIgnorePattern": "config" }]*/
+
+import Controller from '@ember/controller';
+import config from 'travis/config/environment';
+
+export default Controller.extend({
+  config,
+});

app/controllers/build.js

@@ -16,6 +16,8 @@ export default Controller.extend(GithubUrlProperties, Polling, {
 
   @controller('repo') repoController: null,
 
+  config,
+
   @alias('repoController.repo') repo: null,
   @alias('auth.currentUser') currentUser: null,
   @alias('repoController.tab') tab: null,

app/controllers/caches.js

@@ -11,6 +11,8 @@ export default Controller.extend({
 
   @alias('model.repo') repo: null,
 
+  config,
+
   @computed('model.pushes.[]', 'model.pullRequests.[]')
   cachesExist(pushes, pullRequests) {
     if (pushes || pullRequests) {

app/controllers/index.js

@@ -13,6 +13,8 @@ export default Controller.extend({
   @service statusImages: null,
   @service repositories: null,
 
+  config,
+
   init() {
     this._super(...arguments);
     if (!Ember.testing) {

app/controllers/owner.js

@@ -1,11 +1,15 @@
 import Controller from '@ember/controller';
 import { computed } from 'ember-decorators/object';
+import config from 'travis/config/environment';
 
 export default Controller.extend({
   isLoading: false,
 
-  @computed('config.sourceEndpoint', 'model.login')
-  githubProfile(endpoint, login) {
+  config,
+
+  @computed('model.login')
+  githubProfile(login) {
+    const { endpoint } = config;
     return `${endpoint}/${login}`;
   },
 

app/controllers/plans.js

@@ -5,6 +5,8 @@ import { action } from 'ember-decorators/object';
 import { service } from 'ember-decorators/service';
 
 export default Controller.extend({
+  config,
+
   @service auth: null,
 
   @action

app/controllers/repo.js

@@ -8,6 +8,7 @@ import { service } from 'ember-decorators/service';
 import { controller } from 'ember-decorators/controller';
 import { computed } from 'ember-decorators/object';
 import { alias } from 'ember-decorators/object/computed';
+import config from 'travis/config/environment';
 
 export default Controller.extend({
   @service auth: null,
@@ -25,6 +26,8 @@ export default Controller.extend({
   @alias('buildsController.model') builds: null,
   @alias('jobController.job') job: null,
 
+  config,
+
   classNames: ['repo'],
 
   reset() {
@@ -39,7 +42,7 @@ export default Controller.extend({
   init() {
     this._super(...arguments);
     if (!Ember.testing) {
-      Visibility.every(this.config.intervals.updateTimes, this.updateTimes.bind(this));
+      Visibility.every(config.intervals.updateTimes, this.updateTimes.bind(this));
     }
   },
 

app/controllers/settings.js

@@ -1,13 +1,18 @@
+/* eslint no-unused-vars: ["error", { "varsIgnorePattern": "config" }]*/
+
 import Controller from '@ember/controller';
 import { computed } from 'ember-decorators/object';
 import { alias, sort, filterBy } from 'ember-decorators/object/computed';
+import config from 'travis/config/environment';
 
 export default Controller.extend({
   @computed('unsortedEnvVars')
   envVars(envVars) {
     return envVars.sortBy('name');
   },
 
+  config,
+
   @filterBy('model.envVars', 'isNew', false)
   unsortedEnvVars: null,
 

app/routes/account/repositories.js

@@ -1,7 +1,7 @@
 import TravisRoute from 'travis/routes/basic';
 // eslint-disable-next-line
 import config from 'travis/config/environment';
-import { alias } from 'ember-decorators/object/computed';
+import { computed } from 'ember-decorators/object';
 
 export default TravisRoute.extend({
   queryParams: {
@@ -10,7 +10,10 @@ export default TravisRoute.extend({
     }
   },
 
-  @alias('config.pagination.profileReposPerPage') recordsPerPage: null,
+  @computed()
+  recordsPerPage() {
+    return config.pagination.profileReposPerPage;
+  },
 
   model(params) {
     const account = this.modelFor('account');

app/routes/dashboard/repositories.js

@@ -1,9 +1,8 @@
 import { hash } from 'rsvp';
 import TravisRoute from 'travis/routes/basic';
 import dashboardRepositoriesSort from 'travis/utils/dashboard-repositories-sort';
-// eslint-disable-next-line
 import config from 'travis/config/environment';
-import { alias } from 'ember-decorators/object/computed';
+import { computed } from 'ember-decorators/object';
 
 export default TravisRoute.extend({
   queryParams: {
@@ -21,7 +20,10 @@ export default TravisRoute.extend({
     }
   },
 
-  @alias('config.pagination.dashboardReposPerPage') recordsPerPage: null,
+  @computed()
+  recordsPerPage() {
+    return config.pagination.dashboardReposPerPage;
+  },
 
   model(params) {
     const offset = (params.page - 1) * this.get('recordsPerPage');