Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit rejection for unsupported browsers #1655

Merged
merged 8 commits into from May 10, 2018

Conversation

@backspace
Copy link
Contributor

commented May 9, 2018

We don’t have a real browser support policy but this could address one if
we did! To be determined.

Thanks to those in this thread for ideas:
https://discuss.emberjs.com/t/best-practices-for-browser-version-detection/14719/4

I suspect the PR deployment won’t behave as expected, but it does locally.
We’ll see!

@ef4

This comment has been minimized.

Copy link
Contributor

commented on 3250882 May 9, 2018

By the way, when you actually start depending on ui-parser.js inside your check-browser-support.js, you can't reliably usingasync on their script tags, since they can load in either order. It's probably easiest to just copy all the code into one file.

@backspace

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2018

wow good to know, thanks! So fast haha

My true dream would be to magically connect this to targets.js but it’s probably not worth it for something that changes so infrequently.

backspace added some commits May 9, 2018

Move UAParser inside browser-check script
Thanks again to @ef4 for the followup on 3250882!
Update rejection to be for < IE 11 only
This could get more involved with looking for older Safari
version but they seemed to work okay with the bd-ember-3
branch’s targets.

@backspace backspace deployed to org-staging May 10, 2018 Active

@backspace

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2018

This is quite minimal but will suffice to reject IE < 11, which is satisfactory to me for now. 🎉

@backspace backspace merged commit 683a7cb into master May 10, 2018

5 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deployments/com-production Visit a com-production deployment for this commit
Details
deployments/org-production Visit a org-production deployment for this commit
Details
percy/travis-web Visual review automatically approved, no visual changes found.
Details

@backspace backspace deleted the bd-uaparser branch Aug 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.