New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Elm #63
Comments
Can I suggest we look at supporting both:
and
|
@joshk how would that look like for matrix expansion?
are you suggesting this?
|
@svenfuchs you are a star for pointing this out, because now i see four options, which I would like your thoughts on (we could support one or multiple of these formats):
My thoughts:
|
@joshk sorry, missed this. thanks @carlad for the hint! @joshk i agree, i think. essentially this is what we have with other languages except traditionally we would have had i also agree 4 wouldn't be great as this isn't something we do for other languages/things, and adding this to Gatekeeper (i.e. without travis-yml in place) would be a huge mess (on top of the huge mess that we already have), so i think i'd strongly object. one thing to keep in mind though is that we don't have any matrix expansion keys in nested namespaces so far afaik. so that might require some additional work definitely in Gatekeeper, in travis-yml, and possibly in Web (not too sure) |
Anything I can do to help unblock the discussion? |
@svenfuchs so just to confirm, you are also happy with option 3 that @joshk mentions? |
@carlad yes, we're in agreement here. we'd support all of 1-3, but not 4, either eventually or immediately. travis-yml would expand the formats 1 and 2 into the default format 3. i'm not sure if we want to do this work in Gatekeeper, too ... or require the use of travis-yml for this (there are other considerations about doing that, i guess) also, we need to keep the caveat in mind that having an expansion key nested in a namespace is not something that they system supports out of the box. we'll have to make changes to travis-yml, Gatekeeper, and Web for this. |
See travis-ci/travis-build#934
What needs to be supported:
The text was updated successfully, but these errors were encountered: