New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor SafeYAML as LessYAML #4

Merged
merged 1 commit into from Jul 28, 2017

Conversation

Projects
None yet
2 participants
@svenfuchs
Member

svenfuchs commented Jul 28, 2017

We vendor SafeYAML as LessYAML because we currently apply a monkey patch to it that changes the behaviour of parsing certain types globally (e.g. numbers are not turned into numbers, but kept as strings, strings like "on" are not turned into booleans). This might affect YAML parsing in
apps loading this library (e.g. for ActiveRecord serialization or whatever other YAML parsing that happens), and it is desirable to keep this patch local to this library here.

Vendor SafeYAML as LessYAML
We vendor SafeYAML as LessYAML because we currently apply a monkey patch
to it that changes the behaviour of parsing certain types globally (e.g.
numbers are not turned into numbers, but kept as strings, strings like
"on" are not turned into booleans). This might affect YAML parsing in
apps loading this library (e.g. for ActiveRecord serialization or
whatever other YAML parsing that happens), and it is desirable to keep
this patch local to this library here.

@svenfuchs svenfuchs requested a review from carlad Jul 28, 2017

@carlad

carlad approved these changes Jul 28, 2017

@carlad carlad merged commit 3e6aa88 into master Jul 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment