New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "TypeError: no implicit conversion of nil into String" on GET / #61

Merged
merged 1 commit into from Jul 11, 2018

Conversation

Projects
None yet
2 participants
@fsamin
Contributor

fsamin commented Jul 11, 2018

A call on http://localhost:5000 returns a HTTP 500 error instead of a 404 with the following stack trace:

08:49:35 web.1  | 2018-07-11 08:49:35 +0000: Rack app error handling request { GET / }
08:49:35 web.1  | #<TypeError: no implicit conversion of nil into String>
08:49:35 web.1  | /data/travis-yml/lib/travis/yaml/web.rb:10:in `+'
08:49:35 web.1  | /data/travis-yml/lib/travis/yaml/web.rb:10:in `call'
08:49:35 web.1  | /data/travis-yml/lib/travis/yaml/web/basic_auth.rb:11:in `call'
08:49:35 web.1  | /usr/local/bundle/gems/puma-3.11.2/lib/puma/configuration.rb:225:in `call'
08:49:35 web.1  | /usr/local/bundle/gems/puma-3.11.2/lib/puma/server.rb:624:in `handle_request'
08:49:35 web.1  | /usr/local/bundle/gems/puma-3.11.2/lib/puma/server.rb:438:in `process_client'
08:49:35 web.1  | /usr/local/bundle/gems/puma-3.11.2/lib/puma/server.rb:302:in `block in run'
08:49:35 web.1  | /usr/local/bundle/gems/puma-3.11.2/lib/puma/thread_pool.rb:120:in `block in spawn_thread'

the fix is probably not idiomatic ruby, but it solves the problem

Regards

fix: "TypeError: no implicit conversion of nil into String" on GET /
A call on `http://localhost:5000` returns  a HTTP 500 error instead of a 404 with the following stack trace:
```
08:49:35 web.1  | 2018-07-11 08:49:35 +0000: Rack app error handling request { GET / }
08:49:35 web.1  | #<TypeError: no implicit conversion of nil into String>
08:49:35 web.1  | /data/travis-yml/lib/travis/yaml/web.rb:10:in `+'
08:49:35 web.1  | /data/travis-yml/lib/travis/yaml/web.rb:10:in `call'
08:49:35 web.1  | /data/travis-yml/lib/travis/yaml/web/basic_auth.rb:11:in `call'
08:49:35 web.1  | /usr/local/bundle/gems/puma-3.11.2/lib/puma/configuration.rb:225:in `call'
08:49:35 web.1  | /usr/local/bundle/gems/puma-3.11.2/lib/puma/server.rb:624:in `handle_request'
08:49:35 web.1  | /usr/local/bundle/gems/puma-3.11.2/lib/puma/server.rb:438:in `process_client'
08:49:35 web.1  | /usr/local/bundle/gems/puma-3.11.2/lib/puma/server.rb:302:in `block in run'
08:49:35 web.1  | /usr/local/bundle/gems/puma-3.11.2/lib/puma/thread_pool.rb:120:in `block in spawn_thread'
`````

the fix is probably not idiomatic ruby, but it solves the problem

Regards

@joecorcoran joecorcoran merged commit 6ddfdd9 into travis-ci:master Jul 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joecorcoran

This comment has been minimized.

Contributor

joecorcoran commented Jul 11, 2018

Thanks @fsamin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment