New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web app #9

Merged
merged 35 commits into from Jan 23, 2018

Conversation

Projects
None yet
3 participants
@joecorcoran
Contributor

joecorcoran commented Oct 13, 2017

To do:

  • create travis-yml-staging
  • create travis-yml-production
  • create travis-pro-yml-staging
  • create travis-pro-yml-production
  • Handle parse failures
  • Add messages to response
  • Consider security risks
    • Public requests
    • DoS
  • Consider implications of downtime
    • When app is slow
    • When app has crashed
    • When app is deploying
  • set up slack deployments
  • [ ] Drain logs to Papertrail (app needs to be deployed)
  • Sentry
  • Consider production Puma config
  • Force SSL
  • DNS
  • Basic versioning
  • keychain file/s (auth_keys (array of keys apps can use. see trials))
module Travis::Yaml::Web
class Config < Travis::Config
define auth_keys: ['abc123']

This comment has been minimized.

@carlad

carlad Oct 17, 2017

Contributor

Config for auth_keys has been added to keychain and trvs-uploaded to (for the moment) the org-staging app so am thinking this needs to change? Or is this just setting up a placeholder for local/dev work...?

This comment has been minimized.

@joecorcoran

joecorcoran Oct 17, 2017

Contributor

That only gets loaded if the keychain version isn't found. 👍

@joecorcoran joecorcoran changed the title from [WIP] Skeleton web app to [WIP] Web app Oct 17, 2017

@joecorcoran joecorcoran deployed to org-staging Oct 18, 2017 Active

@joecorcoran joecorcoran deployed to org-staging Oct 18, 2017 Active

@joecorcoran joecorcoran deployed to org-staging Oct 18, 2017 Active

@joecorcoran joecorcoran deployed to org-staging Oct 20, 2017 Active

@joecorcoran joecorcoran deployed to org-staging Oct 20, 2017 Active

@joecorcoran joecorcoran deployed to org-staging Nov 2, 2017 Active

@joecorcoran joecorcoran deployed to org-staging Nov 6, 2017 Active

@joecorcoran joecorcoran deployed to org-staging Nov 17, 2017 Active

@joecorcoran joecorcoran deployed to org-staging Nov 17, 2017 Active

joecorcoran added some commits Oct 13, 2017

Skeleton web app
Doesn't do much and isn't very robust, but here we go... 🚀
Add both messages as attrs and full messages
Better for logging etc. to have the full messages, but some
clients would need to the separate message attrs.

Also adds .freeze in a bunch of places for perf.

@carlad carlad deployed to org-staging Jan 15, 2018 Active

@carlad carlad deployed to org-staging Jan 16, 2018 Active

@carlad carlad deployed to org-staging Jan 16, 2018 Active

@carlad carlad deployed to org-staging Jan 16, 2018 Active

Unify alias reference
Because both keys and values can be aliased, we needed a name that
represents both in the alias info messsage. So it's now called
`actual`, and the message is:

"%{alias} is an alias for %{actual}, using %{actual}"

@carlad carlad deployed to org-staging Jan 17, 2018 Active

joecorcoran added some commits Jan 18, 2018

Allow unknown_key to be silenced with underscore
This allows users to define YAML aliases without getting an
unknown_key error. Example:

    _foo: &foo
      bar: 1
    <<: *foo

@joecorcoran joecorcoran deployed to org-staging Jan 23, 2018 Active

@joecorcoran joecorcoran deployed to org-staging Jan 23, 2018 Active

@joecorcoran joecorcoran deployed to org-staging Jan 23, 2018 Active

Add CORS permissions for staging
This is to allow a tester app to make XHR requests.

There is no production use case for CORS at this time.

@joecorcoran joecorcoran deployed to org-staging Jan 23, 2018 Active

@joecorcoran joecorcoran deployed to org-staging Jan 23, 2018 Active

@joecorcoran joecorcoran deployed to org-staging Jan 23, 2018 Active

carlad added some commits Jan 23, 2018

@carlad carlad deployed to org-staging Jan 23, 2018 Active

@carlad carlad deployed to org-staging Jan 23, 2018 Active

@carlad carlad merged commit 275b614 into master Jan 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@carlad carlad deleted the jc-web branch Jan 23, 2018

@keradus

This comment has been minimized.

keradus commented Jan 24, 2018

PR Summary:

WIP (...)

PR Description:

Not ready to merge

was it intended to be merged @carlad ?

@joecorcoran joecorcoran changed the title from [WIP] Web app to Web app Jan 24, 2018

@carlad

This comment has been minimized.

Contributor

carlad commented Jan 25, 2018

@keradus sorry for the confusion. It was ready to merge but I failed to update the title. Thanks @joecorcoran for looking after that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment