New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account custom job timeouts when running script #498

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
3 participants
@bogdanap
Copy link
Contributor

bogdanap commented Sep 13, 2018

What is the problem that this PR is trying to fix?

Custom job timeouts are being ignored after the changes introduced in #492

What approach did you choose and why?

Use the hardtimeout in the jobs start attributes instead of the processor one (which just relies on config)

How can you test this?

tested on staging

What feedback would you like, if any?

@bogdanap bogdanap requested a review from meatballhat Sep 13, 2018

@meatballhat
Copy link
Member

meatballhat left a comment

🎷 🐻

@bogdanap bogdanap merged commit e6dd469 into master Sep 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bogdanap bogdanap deleted the bv-fix-custom-timeout branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment