Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some unrecognized flags as of May 26, 2016 #39

Closed
mdimjasevic opened this issue May 27, 2016 · 2 comments
Closed

Some unrecognized flags as of May 26, 2016 #39

mdimjasevic opened this issue May 27, 2016 · 2 comments

Comments

@mdimjasevic
Copy link
Contributor

Here are a few flags I ran into that WLLVM didn't recognize:

WARNING:Did not recognize the compiler flag "-pedantic"
WARNING:Did not recognize the compiler flag "-print-prog-name=ld"
WARNING:Did not recognize the compiler flag "-pie"
WARNING:Did not recognize the compiler flag "--shared"
WARNING:Did not recognize the compiler flag "debian/libcolord2/usr/lib/x86_64-linux-gnu/libcolord.so.2"
WARNING:Did not recognize the compiler flag "debian/libcolord2/usr/lib/x86_64-linux-gnu/libcolordprivate.so.2"
WARNING:Did not recognize the compiler flag "debian/libcolorhug2/usr/lib/x86_64-linux-gnu/libcolorhug.so.2"

If you need more info for the "debian" flags, just let me know.
@ianamason
Copy link
Collaborator

The - style flags are not that important. The .so.N are important. I fixed the .so (but not the .so.N)
in SRI's fork. I will also fix the .so.N is SRI's fork.

@mdimjasevic
Copy link
Contributor Author

@travitch, @ianamason fixed this issue in a fork and explained in a discussion related to his commit why the fork: SRI-CSL@17f2e85#commitcomment-17641358

Would you consider cherry-picking that commit and putting it here upstream?

Even better, would you guys consider merging the repos? I'm sure everyone involved would benefit from it.

mdimjasevic added a commit to mdimjasevic/whole-program-llvm that referenced this issue Jun 16, 2016
@mdimjasevic
This is a cherry-pick of Ian A. Mason's commit to a fork at:
193a5c5 
SRI-CSL@17f2e85

It partially addresses the issue travitch#39 by adding support for shared
libraries. Other metioned flags stay unsupported with this commit.
@mdimjasevic mdimjasevic mentioned this issue Jun 16, 2016
Merged
travitch added a commit that referenced this issue Jun 17, 2016
@travitch
Merge pull request #40 from mdimjasevic/master
7551aa3 
Partially addresses issue #39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianamason @mdimjasevic