Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] _canceled parameter for some cleanup tasks #1226

Open
civitaspo opened this issue Sep 23, 2019 · 1 comment

Comments

@civitaspo
Copy link

@civitaspo civitaspo commented Sep 23, 2019

Hi all,

I have a feature request. I want _canceled parameter for some cleanup tasks.

When a workflow is canceled, we cannot hook any tasks currently. Sometimes I define a stateful workflow that cannot be defined by one task like using temporary storage. I want to clean up the storage in any case.

ref.

// TODO what should here do if the task is canceled? Add another flag field to TaskRequest
// so that Operator can handle it? Skipping task silently is probably not good idea
// because Operator may want to run cleanup process.

@yoyama

This comment has been minimized.

Copy link
Contributor

@yoyama yoyama commented Oct 4, 2019

@civitaspo Thanks for your proposal. It will be useful.
I don't know we can implement _canceled easily, but I guess we should consider how to support cancelling _canceled tasks. ( normal cancel and forced cancel may be required).
Anyway thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.