Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[feature request] Lifecycle management plugin interface OR Global resource management plugin interface #1238
Hi all, I have a feature request: the lifecycle management plugin interface OR the global resource management plugin interface.
I wrote a plugin digdag-operator-pg_lock that can get locks by PostgreSQL(if you want to know detailed use case, see the plugin README). However I cannot control the connection pool effectively. This is because the current digdag plugin interface does not manage the lifecycle nor the global resource. I want to close the pool when the plugin cache is expired or to define the global connection pool.
Currently the plugin interface has
Because the plugin cache is expired in 10 minutes and re-create the plugin with a new child injector (and the injector is not referenced anywhere after creating the
So I'm in trouble because I can't implement a connection pool well. For the current digdag-operator-pg_lock implementation, the connection pool is closed with the
That's why I want the feature. If you have any other good advice, please let me know...
How is the implementation like the below?