From d2efdfcb6a0637d8495539a654f2cda7054f02d9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timoth=C3=A9e=20Peignier?= <timothee@treasure-data.com>
Date: Tue, 5 Jan 2021 15:58:59 -0800
Subject: [PATCH] Handle client errors (#127)

---
 lib/td/client/api.rb       | 20 +++++++++++++++----
 lib/td/client/api_error.rb | 40 ++++++++++++++++++++++++++++++--------
 2 files changed, 48 insertions(+), 12 deletions(-)

diff --git a/lib/td/client/api.rb b/lib/td/client/api.rb
index e66ee545..287e988d 100644
--- a/lib/td/client/api.rb
+++ b/lib/td/client/api.rb
@@ -636,15 +636,27 @@ def raise_error(msg, res, klass=nil)
       klass
     else
       case status_code
+      when "400"
+        BadRequestError
+      when "401"
+        AuthError
+      when "403"
+        ForbiddenError
       when "404"
         NotFoundError
+      when "405"
+        MethodNotAllowedError
       when "409"
         message = "#{message}: conflicts_with job:#{error["details"]["conflicts_with"]}" if error["details"] && error["details"]["conflicts_with"]
         AlreadyExistsError
-      when "401"
-        AuthError
-      when "403"
-        ForbiddenError
+      when "415"
+        UnsupportedMediaTypeError
+      when "422"
+        UnprocessableEntityError
+      when "429"
+        TooManyRequestsError
+      when /\A4\d\d\z/
+        ClientError
       else
         message = "#{status_code}: #{message}"
         APIError
diff --git a/lib/td/client/api_error.rb b/lib/td/client/api_error.rb
index b8669a79..954a6861 100644
--- a/lib/td/client/api_error.rb
+++ b/lib/td/client/api_error.rb
@@ -13,16 +13,32 @@ def initialize(error_message = nil, api_backtrace = nil)
   end
 end
 
-# 401 API errors
-class AuthError < APIError
+# 4xx Client Errors
+class ClientError < APIError
 end
 
-# 403 API errors, used for database permissions
-class ForbiddenError < APIError
+# 400 Bad Request
+class BadRequestError < ClientError
 end
 
-# 409 API errors
-class AlreadyExistsError < APIError
+# 401 Unauthorized
+class AuthError < ClientError
+end
+
+# 403 Forbidden, used for database permissions
+class ForbiddenError < ClientError
+end
+
+# 404 Not Found
+class NotFoundError < ClientError
+end
+
+# 405 Method Not Allowed
+class MethodNotAllowedError < ClientError
+end
+
+# 409 Conflict
+class AlreadyExistsError < ClientError
   attr_reader :conflicts_with
   def initialize(error_message = nil, api_backtrace = nil, conflicts_with=nil)
     super(error_message, api_backtrace)
@@ -30,8 +46,16 @@ def initialize(error_message = nil, api_backtrace = nil, conflicts_with=nil)
   end
 end
 
-# 404 API errors
-class NotFoundError < APIError
+# 415 Unsupported Media Type
+class UnsupportedMediaTypeError < ClientError
+end
+
+# 422 Unprocessable Entity
+class UnprocessableEntityError < ClientError
+end
+
+# 429 Too Many Requests
+class TooManyRequestsError < ClientError
 end
 
 end