Underscore not permitted at start or end of numeric literal segment #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damieng
changed the title
|
Actually this is allowed 0x_12 and 0b_1010 But otherwise it looks good. |
|
Ah, the joys of them not bothering to actually update a proper spec but just throwing out English language interpretations. Will fix and push again. |
|
I think you now allow binary and hex to end in underscore, which I don't think is allowed. I think you can just swap the star and plus in those regexes. Otherwise test them using regex101.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
_numeric literal support was added it was permitted everywhere in the numeric/hex/boolean literal.It should not be allowed at the start of end of a segment.
We were also missing a test case for real literals starting with a
.Discovered in #131