Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to tree-sitter 0.16 #37

Merged
merged 3 commits into from Jun 22, 2020
Merged

Migrate to tree-sitter 0.16 #37

merged 3 commits into from Jun 22, 2020

Conversation

XVilka
Copy link
Contributor

@XVilka XVilka commented Jun 18, 2020

@XVilka
Copy link
Contributor Author

XVilka commented Jun 18, 2020

There is #36 but it is quite outdated.

@XVilka
Copy link
Contributor Author

XVilka commented Jun 18, 2020

Not sure the reasons behind the failures though (I am not very familiar with Tree Sitter depths):

merlin/tests/test-dirs/errors/typing-after-parsing/test.ml

0 ms	(ERROR [6, 9] - [6, 10])

merlin/tests/test-dirs/completion/parenthesize.ml

0 ms	(ERROR [10, 14] - [10, 15])

merlin/tests/test-dirs/completion/infix.ml

0 ms	(ERROR [8, 9] - [8, 10])

merlin/tests/test-dirs/locate/context-detection/label.ml

0 ms	(ERROR [7, 12] - [7, 14])

@maxbrunsfeld
Copy link
Contributor

This is probably a bug in the latest parser generator. I will try to look into this soon.

@314eter
Copy link
Collaborator

314eter commented Jun 18, 2020

The errors in the merlin tests are known failures, but the test files moved to another directory. The merlin tests include some files with intentional syntax errors to test the error messages.

There are two failures in the ocaml testsuite too, these are caused by new features (ocaml/ocaml#9232 and ocaml/ocaml#9500). I added them to the known failures for now, and will update the grammar later.

I'm still working on #36. I didn't have a lot of time the last few months, but I hope to get it finished soon. I planned to work on semantic support after that. Since #36 will probably have a big impact on the syntax tree, I wanted to get that finsihed first.

@maxbrunsfeld
Copy link
Contributor

Sounds good @314eter, thanks for the update!

@XVilka
Copy link
Contributor Author

XVilka commented Jun 22, 2020

Let me know what I can do to get this merged.

@314eter 314eter merged commit 6b15a40 into tree-sitter:master Jun 22, 2020
@XVilka XVilka deleted the ts-0.16 branch June 22, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants