Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut new release with new ABI 69 #107

Closed
maletor opened this issue Jun 12, 2019 · 5 comments
Closed

Cut new release with new ABI 69 #107

maletor opened this issue Jun 12, 2019 · 5 comments

Comments

@maletor
Copy link
Contributor

@maletor maletor commented Jun 12, 2019

My version of Node has

> process.platform
'linux'
> process.arch
'x64'
> process.versions.modules
'67'
> process.version
'v11.15.0'

can you recompile and release for 67 (and preemptively for 69)?

@issue-label-bot

This comment has been minimized.

Copy link

@issue-label-bot issue-label-bot bot commented Jun 12, 2019

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

@Arcanemagus

This comment has been minimized.

Copy link

@Arcanemagus Arcanemagus commented Jun 12, 2019

Although adding those versions to the prebuild configuration is a good idea, your system should be detecting that there isn't a prebuilt version existing and compiling it locally. Is that not working?

@maletor

This comment has been minimized.

Copy link
Contributor Author

@maletor maletor commented Jun 12, 2019

@Arcanemagus, yes, you are not wrong.

However, as additional context, it should resolve this bug: rubyide/vscode-ruby#486

(Happened before and I believe the maintainer is wanting to switch to WASM to avoid in the future.)

@maletor maletor changed the title Cut new release with new ABI 67 and 69 Cut new release with new ABI 69 Jun 12, 2019
@maletor

This comment has been minimized.

Copy link
Contributor Author

@maletor maletor commented Jun 12, 2019

Moving to #108

@maletor maletor closed this Jun 12, 2019
@wingrunr21

This comment has been minimized.

Copy link
Contributor

@wingrunr21 wingrunr21 commented Jun 12, 2019

Just for color here @Arcanemagus:

This is used in an electron extension in VSCode. The way VSCode handles extensions + the fact it is being consumed via an extension and not in a traditional NPM workflow makes building a new binary on demand more problematic (like lack of build tooling being available).

My long term solve will be to switch over to using the WASM build of tree-sitter but that wasn't available when I first did the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.