From 1f676ad35c6ba5e1fc539e4eac24bb6f03953f41 Mon Sep 17 00:00:00 2001 From: username Date: Fri, 25 Sep 2020 17:34:33 +0900 Subject: [PATCH 1/4] refactor: remove not recommended eslint plugins --- package-lock.json | 24 ------------------------ package.json | 1 - 2 files changed, 25 deletions(-) diff --git a/package-lock.json b/package-lock.json index 1e4f70b..8986828 100644 --- a/package-lock.json +++ b/package-lock.json @@ -3824,15 +3824,6 @@ } } }, - "eslint-plugin-prettier": { - "version": "3.1.3", - "resolved": "https://registry.npmjs.org/eslint-plugin-prettier/-/eslint-plugin-prettier-3.1.3.tgz", - "integrity": "sha512-+HG5jmu/dN3ZV3T6eCD7a4BlAySdN7mLIbJYo0z1cFQuI+r2DiTJEFeF68ots93PsnrMxbzIZ2S/ieX+mkrBeQ==", - "dev": true, - "requires": { - "prettier-linter-helpers": "^1.0.0" - } - }, "eslint-plugin-react": { "version": "7.19.0", "resolved": "https://registry.npmjs.org/eslint-plugin-react/-/eslint-plugin-react-7.19.0.tgz", @@ -4159,12 +4150,6 @@ "resolved": "https://registry.npmjs.org/fast-deep-equal/-/fast-deep-equal-3.1.1.tgz", "integrity": "sha512-8UEa58QDLauDNfpbrX55Q9jrGHThw2ZMdOky5Gl1CDtVeJDPVrG4Jxx1N8jw2gkWaff5UUuX1KJd+9zGe2B+ZA==" }, - "fast-diff": { - "version": "1.2.0", - "resolved": "https://registry.npmjs.org/fast-diff/-/fast-diff-1.2.0.tgz", - "integrity": "sha512-xJuoT5+L99XlZ8twedaRf6Ax2TgQVxvgZOYoPKqZufmJib0tL2tegPBOZb1pVNgIhlqDlA0eO0c3wBvQcmzx4w==", - "dev": true - }, "fast-json-stable-stringify": { "version": "2.1.0", "resolved": "https://registry.npmjs.org/fast-json-stable-stringify/-/fast-json-stable-stringify-2.1.0.tgz", @@ -6789,15 +6774,6 @@ "integrity": "sha512-7PtVymN48hGcO4fGjybyBSIWDsLU4H4XlvOHfq91pz9kkGlonzwTfYkaIEwiRg/dAJF9YlbsduBAgtYLi+8cFg==", "dev": true }, - "prettier-linter-helpers": { - "version": "1.0.0", - "resolved": "https://registry.npmjs.org/prettier-linter-helpers/-/prettier-linter-helpers-1.0.0.tgz", - "integrity": "sha512-GbK2cP9nraSSUF9N2XwUwqfzlAFlMNYYl+ShE/V+H8a9uNl/oUqB1w2EL54Jh0OlyRSd8RfWYJ3coVS4TROP2w==", - "dev": true, - "requires": { - "fast-diff": "^1.1.2" - } - }, "private": { "version": "0.1.8", "resolved": "https://registry.npmjs.org/private/-/private-0.1.8.tgz", diff --git a/package.json b/package.json index 4b4c613..19c5be0 100644 --- a/package.json +++ b/package.json @@ -46,7 +46,6 @@ "eslint": "^7.0.0", "eslint-config-prettier": "^6.11.0", "eslint-plugin-import": "^2.20.2", - "eslint-plugin-prettier": "^3.1.3", "eslint-plugin-react": "^7.19.0", "prettier": "^2.0.5", "redux-devtools-extension": "^2.13.8", From cad739d4aa0b4c2c1623c688c4a839edd81ede21 Mon Sep 17 00:00:00 2001 From: username Date: Fri, 25 Sep 2020 17:56:32 +0900 Subject: [PATCH 2/4] refactor: remove "editor.formatOnPaste" because it is not formatted correctly --- .vscode/settings.json | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 4c08c44..4ca5741 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -16,27 +16,23 @@ }, "[javascript]": { "editor.formatOnSave": true, - "editor.formatOnPaste": true, "editor.codeActionsOnSave": { "source.organizeImports": true } }, "[typescript]": { "editor.formatOnSave": true, - "editor.formatOnPaste": true, "editor.codeActionsOnSave": { "source.organizeImports": true } }, "[typescriptreact]": { "editor.formatOnSave": true, - "editor.formatOnPaste": true, "editor.codeActionsOnSave": { "source.organizeImports": true } }, "[jsonc]": { - "editor.formatOnSave": true, - "editor.formatOnPaste": true + "editor.formatOnSave": true } } From 2d6a24b778ffd654e1871be26255b19a4377b5d5 Mon Sep 17 00:00:00 2001 From: username Date: Fri, 25 Sep 2020 17:58:10 +0900 Subject: [PATCH 3/4] refactor: explicitly set the default formatter to prettier --- .vscode/settings.json | 1 + 1 file changed, 1 insertion(+) diff --git a/.vscode/settings.json b/.vscode/settings.json index 4ca5741..e7e27d7 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -8,6 +8,7 @@ ".next": true }, "files.insertFinalNewline": true, + "editor.defaultFormatter": "esbenp.prettier-vscode", "javascript.format.enable": false, "eslint.enable": true, "eslint.format.enable": true, From b15f7f7236cb3a65357baf5e104517abb12c3262 Mon Sep 17 00:00:00 2001 From: username Date: Fri, 25 Sep 2020 17:59:33 +0900 Subject: [PATCH 4/4] refactor: exclude .now from the search --- .vscode/settings.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index e7e27d7..b7be3b3 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -5,7 +5,8 @@ }, "search.exclude": { "**/node_modules": true, - ".next": true + ".next": true, + ".now": true }, "files.insertFinalNewline": true, "editor.defaultFormatter": "esbenp.prettier-vscode",