cleanup callback #276
Merged
cleanup callback #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Structured callbacks are now available in fsspec>=2024.2.0, so we can remove most of the code here. Almost all of the `dvc_objects.fs.callbacks` is deprecated, and will be removed within 4.x minor release, including TqdmCallback. TqdmCallback can be replaced with fsspec's TqdmCallback, or can be overridden very easily. This will likely be moved to dvc-data for now. Similarly, `dvc_objects._tqdm` module is deprecated and is slated for removal within 4.x minor release. The code will likely move over to dvc-data.
skshetry
force-pushed
the
update-callback
branch
from
73a34f3 to
67ef3eb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
+ Coverage 63.83% 68.84% +5.01%
==========================================
Files 26 27 +1
Lines 2107 2035 -72
Branches 333 338 +5
==========================================
+ Hits 1345 1401 +56
+ Misses 713 584 -129
- Partials 49 50 +1 ☔ View full report in Codecov by Sentry. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structured callbacks are now available in fsspec>=2024.2.0, so we can remove
most of the code here. Almost all of the
dvc_objects.fs.callbacksis deprecated,and will be removed within 4.x minor release, including TqdmCallback.
TqdmCallback can be replaced with fsspec's TqdmCallback, or can be overridden
very easily. This will likely be moved to dvc-data for now.
Similarly,
dvc_objects._tqdmmodule is deprecated and is slated for removal within4.x minor release. The code will likely move over to dvc-data.