-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed as not planned
Labels
enhancementEnhances DVCEnhances DVCp2-mediumMedium priority, should be done, but less importantMedium priority, should be done, but less importantperformanceimprovement over resource / time consuming tasksimprovement over resource / time consuming tasksrefactoringFactoring and re-factoringFactoring and re-factoring
Description
Recent refactoring in #2873 and #2853 implemented isdir(), isfile() and exists(). exists() checks if the given path exists using isdir as well as isfile. isfile simply checks for existence of the blob (in case of s3 and gs), whereas isdir checks if any files with the prefix exists.
.cache_exists() uses .exists(), but does not care about directory paths. So, to reduce number of ._list_paths() remote calls, it's better to refactor .cache_exists() to use isfile.
As @Suor notes here #2873 (comment), isfile might not have been implemented in all remotes, or might be slower in some remotes.
Further infomation: #2873 (comment)
efiop and SuorefiopSuor
Metadata
Metadata
Assignees
Labels
enhancementEnhances DVCEnhances DVCp2-mediumMedium priority, should be done, but less importantMedium priority, should be done, but less importantperformanceimprovement over resource / time consuming tasksimprovement over resource / time consuming tasksrefactoringFactoring and re-factoringFactoring and re-factoring