Skip to content

metrics diff: support numeric string delta for json metrics #3354

@DavidGOrtega

Description

@DavidGOrtega

Hi, python is very problematic serialising JSON floats. With the standard library is very easy to incur in

TypeError: 0.873 is not JSON serializable

also if you specify the value as a float you are giving the control to the JSON parser which may not be very precise, and precision may be here very important.

a_ver :

{"accuracy": "0.8729"}

b_ver

{"accuracy":  "0.8755"}

outputs no diff

{"metrics/eval.json": {"accuracy": {"old": "0.8729", "new": "0.8755"}}} 

or

      Path           Metric    Value         Change                     
metrics/eval.json   accuracy   0.875   diff not supported

Metadata

Metadata

Assignees

No one assigned

    Labels

    awaiting responsewe are waiting for your reply, please respond! :)feature requestRequesting a new feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions