Skip to content

plots show: on Windows generates broken HTML #6894

@shcheklein

Description

@shcheklein

Bug Report

On Windows when plot HTML is generated we don't properly generate DIV ids. Probably the problem is this replace:

div_id = f"plot_{self.filename.replace('.', '_').replace('/', '_')}"

Reproduce

it should be reproducing this to the best of my knowledge, we don't have Windows machine to easily try

Create a an empty project, add a CSV file exp\test.csv in it, add content like this:

true_labels,predicted_labels,predcited_proba
0,1,0.6459952
0,1,0.61865646
0,1,0.6695571
1,1,0.64352757
1,1,0.6563768
1,1,0.62994474

Run dvc plots show -t confusion --open .\exp\test.csv

It should be giving:

Uncaught (in promise) Error: #plot_exp	est_csv does not exist
    at vega-embed@6.18.2:21
    at gi (vega-embed@6.18.2:21)

Expected

You should see a confusion matrix

Environment information

Windows 10, conda

    conda version : 4.10.3
    conda-build version : 3.21.4
    python version : 3.8.5.final.0

Output of dvc doctor:

DVC version: 2.8.2 (conda)
---------------------------------
Platform: Python 3.9.7 on Windows-10-10.0.19043-SP0
Supports:
        gdrive (pydrive2 = 1.10.0),
        webhdfs (fsspec = 2021.10.1),
        http (aiohttp = 3.7.4.post0, aiohttp-retry = 2.4.5),
        https (aiohttp = 3.7.4.post0, aiohttp-retry = 2.4.5)

(dvc version in a project dir is broken due another bug in the dvc version itself)

Metadata

Metadata

Assignees

Labels

bugDid we break something?p1-importantImportant, aka current backlog of things to do

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions