Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Dec 15, 2023

Thanks to treeverse/dvc-objects#262 also makes us less likely to accidentally initialize and authenticate some filesystem while manipulating paths.

E.g. this dvc.yaml

stages:
  eval:
    cmd: "echo test"
    outs:
    - gdrive://storage/data.txt:
        cache: false

would previously cause something as simple as dvc stage list to try to instantiate a gdrive filesystem and thus pop up a web page.

@efiop efiop force-pushed the fs-path branch 2 times, most recently from 24ad02d to 020bad4 Compare December 15, 2023 01:43
efiop added a commit to iterative/gto that referenced this pull request Dec 15, 2023
@efiop efiop force-pushed the fs-path branch 9 times, most recently from e16fa0e to fdc8e7b Compare December 15, 2023 05:29
@codecov
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (766b43b) 90.62% compared to head (c72363c) 90.38%.

Files Patch % Lines
dvc/dependency/base.py 0.00% 4 Missing ⚠️
dvc/fs/dvc.py 91.11% 2 Missing and 2 partials ⚠️
dvc/output.py 85.00% 3 Missing ⚠️
dvc/repo/worktree.py 0.00% 3 Missing ⚠️
dvc/repo/__init__.py 86.66% 1 Missing and 1 partial ⚠️
dvc/repo/artifacts.py 0.00% 2 Missing ⚠️
dvc/repo/index.py 80.00% 2 Missing ⚠️
dvc/config.py 80.00% 1 Missing ⚠️
dvc/data_cloud.py 50.00% 1 Missing ⚠️
dvc/fs/data.py 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10168      +/-   ##
==========================================
- Coverage   90.62%   90.38%   -0.25%     
==========================================
  Files         500      499       -1     
  Lines       37871    37880       +9     
  Branches     5508     5505       -3     
==========================================
- Hits        34322    34238      -84     
- Misses       2909     2979      +70     
- Partials      640      663      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop efiop self-assigned this Dec 15, 2023
@efiop efiop merged commit 3e4e143 into treeverse:main Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant