perf: switch schema validation library #2796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voluptuous is compiling schema to python function, which makes it faster.
shcheklein
approved these changes
Nov 14, 2019
efiop
reviewed
Nov 15, 2019
efiop
reviewed
Nov 15, 2019
| Optional(PARAM_REV): str, | ||
| Optional(PARAM_REV_LOCK): str, | ||
| } | ||
| REPO_SCHEMA = {PARAM_URL: str, PARAM_REV: str, PARAM_REV_LOCK: str} |
Contributor
There was a problem hiding this comment.
So how does it differentiate required field from an optional one?
Contributor
Author
There was a problem hiding this comment.
There is a Required() wrapper.
Suor
changed the title
Contributor
Author
|
Switched config validation to voluptuous too, removed the req for schema. |
Contributor
|
@Suor Please rebase. |
efiop
reviewed
Nov 19, 2019
| "nanotime>=0.5.2", | ||
| "pyasn1>=0.4.1", | ||
| "schema>=0.6.7", | ||
| "voluptuous>=0.11.7", |
Contributor
There was a problem hiding this comment.
Note to self: need to not forget to update it in conda package deps.
pared
approved these changes
Nov 20, 2019
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
voluptuous is compiling schema to a python function, which makes it around 7x faster for me. This is the second slowest part of stage collection, see #2671.
This only replaces schema validation library for stages, config still uses the old one. There is no point in using both, so if everyone is ok with this switch, I will rewrite the config schema too.