-
Notifications
You must be signed in to change notification settings - Fork 1.3k
major deploy tidy #3158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
major deploy tidy #3158
Changes from all commits
5bddfa7
930b6cf
d603048
7b94181
4b16252
d8e6e34
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,8 +3,16 @@ | |
| set -e | ||
|
|
||
| if [[ $TRAVIS_OS_NAME == "osx" && $TRAVIS_OSX_IMAGE != "xcode8.3" ]]; then | ||
| echo false | ||
| exit 0 | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ $TRAVIS_EVENT_TYPE = pull_request || $TRAVIS_EVENT_TPYE = cron ]]; then | ||
| exit 2 | ||
| fi | ||
|
|
||
| # ensure at least one positional arg exists | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what's the reason behind this check, @casperdcl ?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. travis'
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @casperdcl Still don't understand what it is for. What is
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Got it. It is because of globs passed to it. |
||
| if [[ ${#} -ge 1 ]]; then | ||
| [[ -n "$(ls $@ 2>/dev/null)" ]] || exit 3 | ||
| fi | ||
|
|
||
| echo true | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this osx logic - is it still required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@casperdcl Good catch! Not required anymore, it was a leftover from the older days.