From d34aa4471b2e681ef36a64e48eaef743e128d400 Mon Sep 17 00:00:00 2001 From: Casper da Costa-Luis Date: Thu, 16 Jan 2020 20:36:42 +0000 Subject: [PATCH] minor comments - explains review concerns in #3158 --- scripts/ci/deploy_condition.sh | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/scripts/ci/deploy_condition.sh b/scripts/ci/deploy_condition.sh index d4763d9159..9c2a600b5d 100755 --- a/scripts/ci/deploy_condition.sh +++ b/scripts/ci/deploy_condition.sh @@ -2,16 +2,13 @@ set -e -if [[ $TRAVIS_OS_NAME == "osx" && $TRAVIS_OSX_IMAGE != "xcode8.3" ]]; then - exit 1 -fi - if [[ $TRAVIS_EVENT_TYPE = pull_request || $TRAVIS_EVENT_TPYE = cron ]]; then exit 2 fi -# ensure at least one positional arg exists +# positional args are assumed to be file glob patterns to deploy if [[ ${#} -ge 1 ]]; then + # ensure at least one file exists [[ -n "$(ls $@ 2>/dev/null)" ]] || exit 3 fi