Skip to content

Conversation

@skshetry
Copy link
Collaborator

mocker is not expected to work as a context-manager (pytest-dev/pytest-mock#164), and raises a ValueError if done so.

Ref: https://github.com/pytest-dev/pytest-mock#note-about-usage-as-context-manager

@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #3480 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3480   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files         141      141           
  Lines        8582     8582           
=======================================
  Hits         7984     7984           
  Misses        598      598           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f94518...625de04. Read the comment docs.

@skshetry skshetry requested a review from efiop March 15, 2020 12:43
@skshetry skshetry self-assigned this Mar 15, 2020
@skshetry skshetry added the testing Related to the tests and the testing infrastructure label Mar 15, 2020
@skshetry skshetry marked this pull request as ready for review March 15, 2020 12:46
@skshetry skshetry mentioned this pull request Mar 15, 2020
8 tasks
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@skshetry skshetry merged commit d2734df into master Mar 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-pytest-mock branch March 16, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Related to the tests and the testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants