From 311350d8f372c84b0b4bd5404644639d9b078809 Mon Sep 17 00:00:00 2001 From: Casper da Costa-Luis Date: Tue, 17 Mar 2020 14:02:11 +0000 Subject: [PATCH 1/4] template: pr update --- .github/PULL_REQUEST_TEMPLATE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5582aacbe2..8561b5b6e4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,7 +1,7 @@ -* [ ] ❗ Have you followed the guidelines in the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) list? +* [ ] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist -* [ ] 📖 Check this box if this PR **does not** require [documentation](https://dvc.org/doc) updates, or if it does **and** you have created a separate PR in [dvc.org](https://github.com/iterative/dvc.org) with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the [dvc.org](https://github.com/iterative/dvc.org) repo. +* [ ] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or at least issue) in [dvc.org](https://github.com/iterative/dvc.org). If the CLI API is changed, I have updated [tab completion scripts](https://github.com/iterative/dvc/tree/master/scripts/completion). -* [ ] ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs. +* [ ] ❌ I will try to check DeepSource, CodeClimate, and other sanity checks below. (We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.) Thank you for the contribution - we'll try to review it as soon as possible. 🙏 From ef2798e8d63dbbf63ff40f5fb538fea133cf8676 Mon Sep 17 00:00:00 2001 From: Jorge Orpinel Date: Tue, 17 Mar 2020 10:50:55 -0600 Subject: [PATCH 2/4] Update .github/PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 8561b5b6e4..cb23c2ca4f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -* [ ] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist +* [ ] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist. * [ ] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or at least issue) in [dvc.org](https://github.com/iterative/dvc.org). If the CLI API is changed, I have updated [tab completion scripts](https://github.com/iterative/dvc/tree/master/scripts/completion). From fd7ae7db0e57e4e8fbdbce64bfbca6b1a0c8ee6c Mon Sep 17 00:00:00 2001 From: Jorge Orpinel Date: Tue, 17 Mar 2020 10:51:05 -0600 Subject: [PATCH 3/4] Update .github/PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index cb23c2ca4f..100b3600b0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,6 +1,6 @@ * [ ] ❗ I have followed the [Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core) checklist. -* [ ] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or at least issue) in [dvc.org](https://github.com/iterative/dvc.org). If the CLI API is changed, I have updated [tab completion scripts](https://github.com/iterative/dvc/tree/master/scripts/completion). +* [ ] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it here. If the CLI API is changed, I have updated [tab completion scripts](https://github.com/iterative/dvc/tree/master/scripts/completion). * [ ] ❌ I will try to check DeepSource, CodeClimate, and other sanity checks below. (We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.) From 05d1cdfc578dec88455582cfb0b654825f6c4e72 Mon Sep 17 00:00:00 2001 From: Jorge Orpinel Date: Tue, 17 Mar 2020 10:51:15 -0600 Subject: [PATCH 4/4] Update .github/PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 100b3600b0..b50dcdb9ef 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,6 +2,6 @@ * [ ] 📖 If this PR requires [documentation](https://dvc.org/doc) updates, I have created a separate PR (or issue, at least) in [dvc.org](https://github.com/iterative/dvc.org) and linked it here. If the CLI API is changed, I have updated [tab completion scripts](https://github.com/iterative/dvc/tree/master/scripts/completion). -* [ ] ❌ I will try to check DeepSource, CodeClimate, and other sanity checks below. (We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.) +* [ ] ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.) Thank you for the contribution - we'll try to review it as soon as possible. 🙏