Skip to content

Conversation

@skshetry
Copy link
Collaborator

@skshetry skshetry commented Mar 18, 2020

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Fix #3377.

@skshetry skshetry self-assigned this Mar 18, 2020
@skshetry skshetry force-pushed the allow-pull-from-git branch from ba890b9 to 96373e3 Compare March 18, 2020 12:35
@skshetry skshetry force-pushed the allow-pull-from-git branch from 96373e3 to 438d536 Compare March 18, 2020 12:40
When `checkout` or `pull` is done, it'll try to cleanup unused links.
So, when we add from erepo to cache, it creates a link, which DVC will try
to cleanup. Also, it'll provide unwanted checkout change details. So, skipping those
@skshetry skshetry changed the title [WIP] pull: support pulling git-only imports pull: support pulling git-only imports Mar 23, 2020
@skshetry skshetry marked this pull request as ready for review March 23, 2020 11:49
@skshetry skshetry requested review from Suor, pared and pmrowla March 23, 2020 11:50
@skshetry skshetry added bug Did we break something? enhancement Enhances DVC labels Mar 23, 2020
@skshetry skshetry requested a review from efiop March 23, 2020 11:51
Copy link
Contributor

@pmrowla pmrowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

Copy link
Contributor

@pared pared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please take care of leaking file descriptors, mentioned by @efiop.

@efiop efiop merged commit 9fd7d74 into treeverse:master Mar 24, 2020
@efiop
Copy link
Contributor

efiop commented Mar 24, 2020

Thank you @skshetry ! πŸ™

@skshetry skshetry deleted the allow-pull-from-git branch March 25, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Did we break something? enhancement Enhances DVC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure to pull after importing a git repo

4 participants