Skip to content

progress: better threading #3583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2020
Merged

progress: better threading #3583

merged 1 commit into from
Apr 2, 2020

Conversation

@casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Apr 2, 2020 •
edited
Loading

@casperdcl casperdcl added p1-important Important, aka current backlog of things to do ui user interface / interaction labels Apr 2, 2020
@casperdcl casperdcl requested review from efiop and shcheklein April 2, 2020 13:12
@casperdcl casperdcl self-assigned this Apr 2, 2020
@casperdcl casperdcl mentioned this pull request Apr 2, 2020
Closed
@efiop
Copy link
Contributor

efiop commented Apr 2, 2020

You’re not authorized to merge this pull request.

Looks like github is having troubles with PRs right now. Please feel free to merge if you can.

@casperdcl casperdcl merged commit b9d560c into treeverse:master Apr 2, 2020
@casperdcl casperdcl deleted the progress-threaded branch April 2, 2020 21:10
@shcheklein
Copy link
Contributor

shcheklein commented Apr 2, 2020

@xnutsive could you try on your use case and share how does it look like now for you? :)

@natikgadzhi
Copy link
Contributor

natikgadzhi commented Apr 4, 2020 •
edited
Loading

Just had a chance to dvc pull with dvc 0.92.0 — it used a single merged progress bar 👏

upd not a single bar, but no bar flickering, so — much better.

@casperdcl casperdcl mentioned this pull request Apr 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shcheklein shcheklein Awaiting requested review from shcheklein

1 more reviewer

@efiop efiop efiop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@casperdcl casperdcl

Labels

p1-important Important, aka current backlog of things to do ui user interface / interaction

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pull/fetch: progress bar is all over the console output

4 participants

@casperdcl @efiop @shcheklein @natikgadzhi