Skip to content

analytics: collect runtime info in the worker #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efiop merged 1 commit into from
Apr 8, 2020
Merged

analytics: collect runtime info in the worker #3610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions dvc/analytics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def collect_and_send_report(args=None, return_code=None):
report as a JSON, where the _collector_ generates it and the _sender_
removes it after sending it.
"""
report = _runtime_info()
report = {}

# Include command execution information on the report only when available.
if args and hasattr(args, "func"):
Expand All @@ -62,7 +62,7 @@ def is_enabled():
return enabled


def send(report):
def send(path):
"""
Side effect: Removes the report after sending it.

Expand All @@ -73,13 +73,17 @@ def send(report):
url = "https://analytics.dvc.org"
headers = {"content-type": "application/json"}

with open(report, "rb") as fobj:
try:
requests.post(url, data=fobj, headers=headers, timeout=5)
except requests.exceptions.RequestException:
logger.debug("failed to send analytics report", exc_info=True)
with open(path, "r") as fobj:
report = json.load(fobj)

os.remove(report)
report.update(_runtime_info())

try:
requests.post(url, json=report, headers=headers, timeout=5)
except requests.exceptions.RequestException:
logger.debug("failed to send analytics report", exc_info=True)

os.remove(path)


def _scm_in_use():
Expand Down