hooks: pylint: fix pre-commit #4146
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylintpre-commit hook.pre-commit-config.yamlstates that thepylinthook is defined locally, yet.pre-commit-hooks.yamlfails to define it. As a result, attempting to commit will result in an error.Defining the hook's language as
systemand asking devs to manually runpip install .[tests]goes against fundamental principles of pre-commit hooks. None of the other hooks require this.In any case
pylintitself defines https://github.com/PyCQA/pylint/blob/master/.pre-commit-hooks.yaml so we should just use theirs.