Skip to content

Conversation

@skshetry
Copy link
Collaborator

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Test PR will later work on top of #4295

@skshetry
Copy link
Collaborator Author

skshetry commented Aug 11, 2020

Tests passed. Thing to do here are:

  1. work this on top of force YAML 1.1 syntax when dumping yaml files with ruamelΒ #4295 (with only dump in 1.1 in dvc.lock files and .dvc files).
  2. ask for feedback.
  3. See how much this hurts the compatibility.
  4. If I don't find anything new and is compatible, release a new minor version (patch won't do).
  5. Fix json loading.
  6. Document that dvc.yaml is expected to be "1.1 and 1.2 compatible", i.e. compatible subset of either two, and
    ".dvc file" is expected to be in 1.1.

@efiop, it'd be good to get quick feedback on this PR as it is.

Closing for now. See you on the other side, #4295 that is.

@skshetry skshetry closed this Aug 11, 2020
@skshetry skshetry deleted the fix-1.1-lock branch August 12, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant