From 4d0b5545716726a8413cbfcf08127321cf2239e4 Mon Sep 17 00:00:00 2001 From: Ivan Rubanov Date: Wed, 26 Aug 2020 20:49:46 +0300 Subject: [PATCH 1/3] version: improve link type detection fall back If failed to determine cache type print link to related web page. Fixes #2788 --- dvc/command/version.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/dvc/command/version.py b/dvc/command/version.py index 79452c6d33..a900ef6f01 100644 --- a/dvc/command/version.py +++ b/dvc/command/version.py @@ -10,7 +10,7 @@ from dvc.exceptions import DvcException, NotDvcRepoError from dvc.scm.base import SCMError from dvc.system import System -from dvc.utils import relpath +from dvc.utils import error_link from dvc.utils.pkg import PKG from dvc.version import __version__ @@ -59,12 +59,8 @@ def run(self): fs_type = self.get_fs_type(repo.cache.local.cache_dir) info.append(f"Cache directory: {fs_type}") else: - logger.warning( - "Unable to detect supported link types, as cache " - "directory '{}' doesn't exist. It is usually auto-created " - "by commands such as `dvc add/fetch/pull/run/import`, " - "but you could create it manually to enable this " - "check.".format(relpath(repo.cache.local.cache_dir)) + info.append( + "Cache types: " + error_link("unable-to-detect-cache-type") ) except NotDvcRepoError: From 943fa3d31934e7c1dd40fec6f38b8100ef6b7548 Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Thu, 3 Sep 2020 02:55:04 +0300 Subject: [PATCH 2/3] Update dvc/command/version.py --- dvc/command/version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dvc/command/version.py b/dvc/command/version.py index a900ef6f01..cd3a6ccc64 100644 --- a/dvc/command/version.py +++ b/dvc/command/version.py @@ -60,7 +60,7 @@ def run(self): info.append(f"Cache directory: {fs_type}") else: info.append( - "Cache types: " + error_link("unable-to-detect-cache-type") + "Cache types: " + error_link("no-dvc-cache") ) except NotDvcRepoError: From 0f9a48c8215aca0a8916da0ac507e2dec87e18d2 Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Thu, 3 Sep 2020 03:11:00 +0300 Subject: [PATCH 3/3] fix formatting --- dvc/command/version.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dvc/command/version.py b/dvc/command/version.py index cd3a6ccc64..aa37106c0e 100644 --- a/dvc/command/version.py +++ b/dvc/command/version.py @@ -59,9 +59,7 @@ def run(self): fs_type = self.get_fs_type(repo.cache.local.cache_dir) info.append(f"Cache directory: {fs_type}") else: - info.append( - "Cache types: " + error_link("no-dvc-cache") - ) + info.append("Cache types: " + error_link("no-dvc-cache")) except NotDvcRepoError: root_directory = os.getcwd()