-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Keep status output format consistents
#4490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix#4482 According to the discussion. Make `DVC status [outputs]` output format the same with `DVC status [stages]` instead of `DVC status -c [outputs]`
skshetry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karajan1001, I understand that the output format is not good. I find it quite ugly too (what's with the indent, right? 😄 ). If you have a good output format, please do suggest.
I have no issues with the previous output format, I only wanted the dvc's internals to be consistent, as it could affect other --show-json functionalities. 🙂
@karajan1001, Thanks for the contributions. 🎉
|
Maybe we should go with git-like status: cc @karajan1001 |
@skshetry |
|
Thank you @karajan1001 ! 🙏 |
|
Hi there! This PR probably implies several changes to the sample outputs of |
|
@jorgeorpinel, this does not change any output formats at all. Let's say you have a stage, "stage1" with outputs "out1" and "out2". So, if you do $ dvc status stage1
stage1:
changed outs:
deleted: out1
deleted: out2And, if you just do $ dvc status out1
stage1:
changed outs:
deleted: out1This PR just rollbacked a different output format that was temporarily there. |
|
Okay, well I noticed we have some really outdated status outputs in docs thanks to this issue. We'll address that separately, then. Thanks |
fix #4482
According to the discussion. Make
DVC status [outputs]output format the same withDVC status [stages]instead ofDVC status -c [outputs]❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏