Skip to content

Conversation

@karajan1001
Copy link
Contributor

@karajan1001 karajan1001 commented Aug 28, 2020

fix #4482
According to the discussion. Make DVC status [outputs] output format the same with DVC status [stages] instead of DVC status -c [outputs]

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

fix#4482
According to the discussion. Make `DVC status [outputs]` output format the same with `DVC status [stages]` instead of `DVC status -c [outputs]`
@pared pared requested review from pared and skshetry August 28, 2020 11:19
@skshetry skshetry added enhancement Enhances DVC ui user interface / interaction labels Aug 28, 2020
Copy link
Collaborator

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karajan1001, I understand that the output format is not good. I find it quite ugly too (what's with the indent, right? 😄 ). If you have a good output format, please do suggest.

I have no issues with the previous output format, I only wanted the dvc's internals to be consistent, as it could affect other --show-json functionalities. 🙂

@karajan1001, Thanks for the contributions. 🎉

@skshetry
Copy link
Collaborator

Maybe we should go with git-like status:

modified: foo.txt (dvc.yaml:stage_one)
modified: foobar (foobar.dvc)
modified: dir

cc @karajan1001

@karajan1001
Copy link
Contributor Author

Maybe we should go with git-like status:

modified: foo.txt (dvc.yaml:stage_one)
modified: foobar (foobar.dvc)
modified: dir

cc @karajan1001

@skshetry
I had considered this format too, in the previous PR. Both are ok I think.

@efiop efiop merged commit 777a23a into treeverse:master Aug 30, 2020
@efiop
Copy link
Contributor

efiop commented Aug 30, 2020

Thank you @karajan1001 ! 🙏

jorgeorpinel added a commit to treeverse/dvc.org that referenced this pull request Sep 23, 2020
@jorgeorpinel
Copy link
Contributor

Hi there! This PR probably implies several changes to the sample outputs of status commands throughout all docs. I started doing some of these changes in treeverse/dvc.org@6fc5e8b but we should probably double check them all. Would you like to try that, @karajan1001 ?

@skshetry
Copy link
Collaborator

@jorgeorpinel, this does not change any output formats at all. Let's say you have a stage, "stage1" with outputs "out1" and "out2".

So, if you do dvc status stage1, you'll see:

$ dvc status stage1
stage1:
	changed outs:
		deleted:            out1
		deleted:            out2

And, if you just do dvc status out1, you'll see filtered results:

$ dvc status out1
stage1:
	changed outs:
		deleted:            out1

This PR just rollbacked a different output format that was temporarily there.

@jorgeorpinel
Copy link
Contributor

Okay, well I noticed we have some really outdated status outputs in docs thanks to this issue. We'll address that separately, then. Thanks

@karajan1001 karajan1001 deleted the fix_4482 branch April 7, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhances DVC ui user interface / interaction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discuss whether we should have consistent output format for both dvc status and dvc status -c.

5 participants