command: add dvc push instruction after dvc repro #4737
Conversation
Adds a logger.info() statement to remind the user to run dvc push after running dvc repro. Fixes #2359
dvc/command/repro.py
Outdated
| logger.info(_show_metrics(metrics)) | ||
|
|
||
| logger.info( | ||
| "To save your updates to remote storage, run 'dvc push'." |
There was a problem hiding this comment.
Maybe something like "Use 'dvc push' to send your updates to remote storage."?
dvc/command/repro.py
Outdated
| logger.info( | ||
| "Use 'dvc push' to send your updates to remote storage." | ||
| ) |
There was a problem hiding this comment.
Two more things:
- please use ` instead of ' - to keep consistency with other help messages
- I think we should move this message few lines up and log it under
if len(stages)==0inelsecause, so that we will not get this message when there is nothing actually reproduced.
What do you think @jvfe?
There was a problem hiding this comment.
Sorry, I don't really understand what you mean by using "instead of" in this context, could you explain further?
Also, sounds good putting an else statement below if len(stages)==0, like this, right?
if len(stages) == 0:
logger.info(CmdDataStatus.UP_TO_DATE_MSG)
else:
logger.info(
"Use 'dvc push' to send your updates to remote storage."
)There was a problem hiding this comment.
@jvfe I mean backticks ( ` ) instead of ticks ( ' ) - sorry its hard to highlit them, due to markdown formatting.
There was a problem hiding this comment.
Ok, thanks for explaining! I've done what you suggested but had to split the message in two lines or the pre-commit hook for flake8 would complain.
|
Seems like builds are failing for an unrelated reason. |
| "Use `dvc push` to send your updates to " | ||
| "remote storage." |
There was a problem hiding this comment.
Minor: Should we update some of the console examples in https://dvc.org/doc/command-reference/repro? Several show the command's output.
p.s. looks like that could fit in a single-line-string in the code?
There was a problem hiding this comment.
This is a good point, but there is a problem:
In the example, in repro we modify code only, without influence on the output of the stage...
Seems to me like we should not display this help message there. So I would say we should not update the command reference but fix the underlying issue.
5 participants
Adds a logger.info() statement to remind the user to run dvc push after
running dvc repro.
Closes #2359
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏